-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated check on model step output types from dict to Mapping #18657
Updated check on model step output types from dict to Mapping #18657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid! LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18657 +/- ##
==========================================
- Coverage 84% 50% -33%
==========================================
Files 427 418 -9
Lines 33410 33235 -175
==========================================
- Hits 27901 16770 -11131
- Misses 5509 16465 +10956 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still use "dict" in the error messages. Most people don't understand the difference between them.
What does this PR do?
Fixes #17649
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18657.org.readthedocs.build/en/18657/