Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated check on model step output types from dict to Mapping #18657

Merged

Conversation

nik777
Copy link
Contributor

@nik777 nik777 commented Sep 27, 2023

What does this PR do?

Fixes #17649

Before submitting
  • [x]Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • [ x] Did you read the contributor guideline, Pull Request section?
  • [ x] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [ x] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18657.org.readthedocs.build/en/18657/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 27, 2023
@nik777 nik777 marked this pull request as ready for review September 28, 2023 00:26
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! LGTM

@awaelchli awaelchli added the community This PR is from the community label Sep 28, 2023
@awaelchli awaelchli added this to the 2.1 milestone Sep 28, 2023
@awaelchli awaelchli added the lightningmodule pl.LightningModule label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #18657 (3d0f542) into master (f8e6fa4) will decrease coverage by 33%.
Report is 2 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18657      +/-   ##
==========================================
- Coverage      84%      50%     -33%     
==========================================
  Files         427      418       -9     
  Lines       33410    33235     -175     
==========================================
- Hits        27901    16770   -11131     
- Misses       5509    16465   +10956     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still use "dict" in the error messages. Most people don't understand the difference between them.

@mergify mergify bot added the ready PRs ready to be merged label Sep 28, 2023
@awaelchli awaelchli merged commit ac71365 into Lightning-AI:master Sep 29, 2023
88 of 92 checks passed
@nik777 nik777 deleted the feature/17649_model_step_Mapping branch February 6, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community lightningmodule pl.LightningModule pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen check on model step output types from dict to Mapping
3 participants