Avoid passing process group to enable FSDP's hybrid-shard #18583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
awaelchli
added
feature
awaelchli
requested review from
carmocca,
justusschock,
Borda,
williamFalcon,
edenlightning and
lantiga
as code owners
carmocca
approved these changes
Sep 19, 2023
| @@ -203,12 +202,9 @@ def num_processes(self) -> int: | |||
|
|
|||
| @property | |||
| def process_group(self) -> Optional[ProcessGroup]: | |||
There was a problem hiding this comment.
I would suggest removing this property, since we don't use it and it'll be a problem if we ever finish the collectives refactor
There was a problem hiding this comment.
It's easy to avoid the breaking change here the way I did, and so I would like to avoid it unless absolutely necessary. If we need to remove it in the future, we can always do it with the justification needed at that time.
There was a problem hiding this comment.
If you still think the property should be removed, could you make the PR for it?
Borda
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Alternative approach to #18562.
Fixes #18552
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18583.org.readthedocs.build/en/18583/
cc @Borda @carmocca @justusschock @awaelchli