Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trainer's log_dir method for CSVLogger #18548

Merged

Conversation

ioangatop
Copy link
Contributor

@ioangatop ioangatop commented Sep 13, 2023

What does this PR do?

Fixes #18547

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18548.org.readthedocs.build/en/18548/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 13, 2023
@ioangatop ioangatop changed the title fix trainer log_dir method for CSVLogger Fix Trainer's log_dir method for CSVLogger Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #18548 (2b84b41) into master (3a59462) will decrease coverage by 35%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18548      +/-   ##
==========================================
- Coverage      85%      50%     -35%     
==========================================
  Files         427      419       -8     
  Lines       33396    33251     -145     
==========================================
- Hits        28437    16774   -11663     
- Misses       4959    16477   +11518     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I think this is reasonable since CSVLogger follows the same design as TensorBoardLogger, so this LGTM. I also added a test for it.

@awaelchli awaelchli added bug Something isn't working community This PR is from the community labels Sep 20, 2023
@mergify mergify bot added the ready PRs ready to be merged label Sep 20, 2023
@awaelchli awaelchli force-pushed the fix-trainer-log_dir_for-csvlogger branch from 9abbb62 to 4e337c8 Compare September 20, 2023 23:13
ioangatop and others added 3 commits September 21, 2023 01:16
Co-authored-by: Tianshu Wang <[email protected]>
Co-authored-by: Tianshu Wang <[email protected]>
Co-authored-by: Tianshu Wang <[email protected]>
Co-authored-by: Tianshu Wang <[email protected]>
Co-authored-by: Tianshu Wang <[email protected]>
Co-authored-by: Tianshu Wang <[email protected]>
@awaelchli awaelchli force-pushed the fix-trainer-log_dir_for-csvlogger branch from f1058d2 to 4f5eade Compare September 20, 2023 23:17
@awaelchli awaelchli merged commit 3e2cd24 into Lightning-AI:master Sep 20, 2023
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community This PR is from the community logger: csv pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_dir in Trainer is wrong for CSVLogger
3 participants