-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Trainer
's log_dir
method for CSVLogger
#18548
Merged
awaelchli
merged 4 commits into
Lightning-AI:master
from
ioangatop:fix-trainer-log_dir_for-csvlogger
Sep 20, 2023
Merged
Fix Trainer
's log_dir
method for CSVLogger
#18548
awaelchli
merged 4 commits into
Lightning-AI:master
from
ioangatop:fix-trainer-log_dir_for-csvlogger
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioangatop
requested review from
williamFalcon,
tchaton,
awaelchli and
carmocca
as code owners
September 13, 2023 16:14
ioangatop
changed the title
fix trainer log_dir method for CSVLogger
Fix Sep 13, 2023
Trainer
's log_dir
method for CSVLogger
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18548 +/- ##
==========================================
- Coverage 85% 50% -35%
==========================================
Files 427 419 -8
Lines 33396 33251 -145
==========================================
- Hits 28437 16774 -11663
- Misses 4959 16477 +11518 |
awaelchli
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I think this is reasonable since CSVLogger follows the same design as TensorBoardLogger, so this LGTM. I also added a test for it.
awaelchli
added
bug
Something isn't working
community
This PR is from the community
labels
Sep 20, 2023
Borda
approved these changes
Sep 20, 2023
awaelchli
force-pushed
the
fix-trainer-log_dir_for-csvlogger
branch
from
September 20, 2023 23:13
9abbb62
to
4e337c8
Compare
Co-authored-by: Tianshu Wang <[email protected]> Co-authored-by: Tianshu Wang <[email protected]>
Co-authored-by: Tianshu Wang <[email protected]> Co-authored-by: Tianshu Wang <[email protected]>
Co-authored-by: Tianshu Wang <[email protected]> Co-authored-by: Tianshu Wang <[email protected]>
awaelchli
force-pushed
the
fix-trainer-log_dir_for-csvlogger
branch
from
September 20, 2023 23:17
f1058d2
to
4f5eade
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
community
This PR is from the community
logger: csv
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18547
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18548.org.readthedocs.build/en/18548/