-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the batch_idx argument optional in all step methods #18512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x404
requested review from
williamFalcon,
awaelchli,
carmocca and
justusschock
as code owners
September 9, 2023 12:04
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18512 +/- ##
==========================================
- Coverage 85% 50% -35%
==========================================
Files 427 419 -8
Lines 33372 33240 -132
==========================================
- Hits 28373 16703 -11670
- Misses 4999 16537 +11538 |
carmocca
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
carmocca
added
feature
Is an improvement or enhancement
hooks
Related to the hooks API
loops
Related to the Loop API
trainer: validate
trainer: test
trainer: predict
community
This PR is from the community
labels
Sep 10, 2023
awaelchli
approved these changes
Sep 10, 2023
awaelchli
reviewed
Sep 10, 2023
awaelchli
reviewed
Sep 10, 2023
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
This PR is from the community
feature
Is an improvement or enhancement
hooks
Related to the hooks API
loops
Related to the Loop API
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
trainer: predict
trainer: test
trainer: validate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
make
batch_idx
argument optional intest_step
,validation_step
andpredict_step
.Fixes #18506
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18512.org.readthedocs.build/en/18512/