Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the batch_idx argument optional in all step methods #18512

Merged
merged 10 commits into from
Sep 11, 2023

Conversation

0x404
Copy link
Contributor

@0x404 0x404 commented Sep 9, 2023

What does this PR do?

make batch_idx argument optional in test_step, validation_step and predict_step.

Fixes #18506

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18512.org.readthedocs.build/en/18512/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 9, 2023
@0x404 0x404 marked this pull request as draft September 9, 2023 12:08
@0x404 0x404 marked this pull request as ready for review September 9, 2023 13:10
@0x404 0x404 requested a review from Borda as a code owner September 9, 2023 13:10
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #18512 (2c0cc5a) into master (4dfc09c) will decrease coverage by 35%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18512      +/-   ##
==========================================
- Coverage      85%      50%     -35%     
==========================================
  Files         427      419       -8     
  Lines       33372    33240     -132     
==========================================
- Hits        28373    16703   -11670     
- Misses       4999    16537   +11538     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/tests_pytorch/loops/test_evaluation_loop.py Outdated Show resolved Hide resolved
@carmocca carmocca added feature Is an improvement or enhancement hooks Related to the hooks API loops Related to the Loop API trainer: validate trainer: test trainer: predict community This PR is from the community labels Sep 10, 2023
@carmocca carmocca added this to the 2.1 milestone Sep 10, 2023
@mergify mergify bot added the ready PRs ready to be merged label Sep 10, 2023
@carmocca carmocca merged commit a0d6fcc into Lightning-AI:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement hooks Related to the hooks API loops Related to the Loop API pl Generic label for PyTorch Lightning package ready PRs ready to be merged trainer: predict trainer: test trainer: validate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the batch_idx argument optional in all step methods
3 participants