-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta device initialization for FSDP in Trainer #18385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
feature
Is an improvement or enhancement
strategy: fsdp
Fully Sharded Data Parallel
pl
Generic label for PyTorch Lightning package
labels
Aug 24, 2023
for more information, see https://pre-commit.ci
awaelchli
commented
Aug 24, 2023
awaelchli
requested review from
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
August 24, 2023 23:48
awaelchli
commented
Aug 24, 2023
Borda
approved these changes
Aug 25, 2023
carmocca
approved these changes
Aug 25, 2023
Co-authored-by: Jirka Borovec <[email protected]>
awaelchli
commented
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: fsdp
Fully Sharded Data Parallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Same approach as in #18122
This allows you to instantiate very large models that wouldn't fit in memory (either CPU or GPU) as fast as possible. No memory for weights get allocated, neither in CPU nor GPU memory and parameters are materialized/initialized with random weights directly at the time the model gets wrapped and sharded in
FSDPStrategy.setup()
.Notes:
reset_parameters()
pytorch/pytorch#104187 in PyTorch 2.1 nightly.Requirement: Your submodules define a
reset_parameters()
method that can be called to init the params. This is the case for all (most) built-in PyTorch layers. If you have a custom layer, you'd have to add that method. This PR also updates our Trainsformers example that needs thisreset_parameters()
fixed.cc @Borda @awaelchli @carmocca