Change auto-device selection for Jupyter notebook environments #18291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nto feature/auto-device-notebooks
for more information, see https://pre-commit.ci
…nto feature/auto-device-notebooks
awaelchli
changed the title
awaelchli
requested review from
carmocca,
justusschock,
Borda,
williamFalcon,
edenlightning and
lantiga
as code owners
Borda
approved these changes
Aug 18, 2023
carmocca
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
I must say that I would prefer the alternative of keeping the current behavior - which is consistent with all other environments - and suggesting the possibility of running with devices=1 if things go wrong.
It would also avoid having to revert this breaking change again (meaning another breaking change) if support for multi-GPU environments with notebooks improves in the future.
However, I don't have a strong enough opinion to block this, so here's my stamp to proceed if you feel comfortable making this change
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18291 +/- ##
=========================================
- Coverage 85% 62% -23%
=========================================
Files 427 422 -5
Lines 33138 33054 -84
=========================================
- Hits 28188 20406 -7782
- Misses 4950 12648 +7698 |
mergify
bot
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18281
This PR changes the
devices="auto"behavior when running inside a Jupyter notebook.Before:
Now:
We've seen multiple reports similar to #18281 with users reporting segmentation faults and CUDA issues. These are at the moment too hard to address. For a better user experience, we propose to switch the default back and add an info message that multiple devices may be used, but the feature is currently considered "unstable".
cc @Borda @justusschock @carmocca @awaelchli