Avoid reinstantiation of DataLoader if distributed sampler not required #18191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
feature
for more information, see https://pre-commit.ci
…n' into fabric/dataloader-reinstantiation
awaelchli
added
the
fun
justusschock
approved these changes
Jul 31, 2023
Borda
approved these changes
Aug 1, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18191 +/- ##
=========================================
- Coverage 83% 61% -22%
=========================================
Files 431 426 -5
Lines 33073 32983 -90
=========================================
- Hits 27461 20139 -7322
- Misses 5612 12844 +7232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18106
Previously, Fabric would re-instantiate the data loader regardless whether a sampler needs to be replaced or not. This is redundant but usually not a problem, but had some unneeded restrictions in making the batch sampler conform to a certain interface. The PR lifts this restriction and only calls for dataloader re-instantiation if a distributed sampler is actually needed. The tests have been updated accordingly.
cc @Borda @justusschock @awaelchli @carmocca