-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum wandb version from 0.12.0 to 0.12.10 #18171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
carmocca,
justusschock,
williamFalcon,
lantiga,
Borda and
tchaton
as code owners
July 26, 2023 22:15
awaelchli
added
logger: wandb
Weights & Biases
feature
Is an improvement or enhancement
labels
Jul 26, 2023
github-actions
bot
added
pl
Generic label for PyTorch Lightning package
and removed
feature
Is an improvement or enhancement
labels
Jul 26, 2023
for more information, see https://pre-commit.ci
Borda
approved these changes
Jul 26, 2023
carmocca
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this CHANGELOG worthy? Probably not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
logger: wandb
Weights & Biases
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #18051 (comment)
The check here
https://github.com/Lightning-AI/lightning/blob/6511ac28759718a524dd00e627c186fb6baea763/src/lightning/pytorch/loggers/wandb.py#L349-L356
was too fragile, skipped without the user noticing (due to version conflict).
My proposal is to require the minimum version to be 0.12.10 so that we don't have to do fragile checks at runtime, and fail at the beginning when user tries to instantiate the WandbLogger without the proper version installed.
wandb 0.12.10 was published in Feb 2022. If there are concerns that this is too small of a version window, we should hold off with this PR.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @awaelchli @morganmcg1 @borisdayma @scottire @parambharat