New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cluster commands from CLI #18151

Merged

lantiga merged 12 commits into master from remove-cluster-commands

Jul 27, 2023

Collaborator

lantiga commented Jul 24, 2023 •

edited by github-actions bot

Loading

What does this PR do?

This PR removes deprecated cloud functionality from the CLI. The removal has no effect on existing users.

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

lantiga requested review from tchaton, awaelchli, ethanwharris, williamFalcon and Borda as code owners

July 24, 2023 16:33

github-actions bot added the app (removed) label

Contributor

github-actions bot commented Jul 24, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 fabric: Docs

Check ID	Status
make-doctest (fabric)	success	✅
make-html (fabric)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_data: CPU workflow

Check ID	Status
data-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
data-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
data-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to pyproject.toml.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/cmd_apps.py, src/lightning/app/cli/cmd_clusters.py, src/lightning/app/cli/cmd_ssh_keys.py, src/lightning/app/cli/connect/maverick.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_create.py, src/lightning/app/cli/lightning_cli_delete.py, src/lightning/app/cli/lightning_cli_list.py, src/lightning/app/runners/runtime.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_logs.py, src/lightning/app/utilities/cluster_logs.py, src/lightning/app/utilities/logs_socket_api.py, src/lightning/app/utilities/packaging/app_config.py, tests/tests_app/cli/test_cli.py, tests/tests_app/cli/test_cmd_apps.py, tests/tests_app/cli/test_cmd_cli_delete.py, tests/tests_app/cli/test_cmd_clusters.py, tests/tests_app/cli/test_cmd_show_cluster_logs.py, tests/tests_app/cli/test_cmd_ssh.py, tests/tests_app/cli/test_cmd_ssh_keys.py, tests/tests_app/cli/test_connect_maverick.py, tests/tests_app/cli/test_run_app.py, tests/tests_app/components/multi_node/test_fabric.py, tests/tests_app/components/multi_node/test_trainer.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/utilities/test_logs_socket_api.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/cli/cmd_apps.py, src/lightning/app/cli/cmd_clusters.py, src/lightning/app/cli/cmd_ssh_keys.py, src/lightning/app/cli/connect/maverick.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_create.py, src/lightning/app/cli/lightning_cli_delete.py, src/lightning/app/cli/lightning_cli_list.py, src/lightning/app/runners/runtime.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_logs.py, src/lightning/app/utilities/cluster_logs.py, src/lightning/app/utilities/logs_socket_api.py, src/lightning/app/utilities/packaging/app_config.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/cli/cmd_apps.py, src/lightning/app/cli/cmd_clusters.py, src/lightning/app/cli/cmd_ssh_keys.py, src/lightning/app/cli/connect/maverick.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_create.py, src/lightning/app/cli/lightning_cli_delete.py, src/lightning/app/cli/lightning_cli_list.py, src/lightning/app/runners/runtime.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_logs.py, src/lightning/app/utilities/cluster_logs.py, src/lightning/app/utilities/logs_socket_api.py, src/lightning/app/utilities/packaging/app_config.py, docs/source-app/cloud/customize_a_lightning_cluster.rst, docs/source-app/glossary/aws_arn.rst, docs/source-app/glossary/command_lines/command_lines.rst, docs/source-app/glossary/index.rst, docs/source-app/levels/basic/build_a_lightning_component.rst, docs/source-app/levels/basic/hello_components/code_run_cloud_yours.bash, docs/source-app/levels/basic/hello_components/code_run_cloud_yours_setup.bash, docs/source-app/levels/basic/hello_components/terraform_example.bash, docs/source-app/levels/basic/hero_run.rst, docs/source-app/levels/basic/hero_run_setup.rst, docs/source-app/levels/basic/real_lightning_component_implementations.rst, docs/source-app/levels/basic/run_on_aws_account.rst, docs/source-app/levels/basic/save_money_on_cloud_costs.rst, docs/source-app/levels/expert/index.rst, docs/source-app/levels/intermediate/connect_lightning_components.rst, docs/source-app/levels/intermediate/level_2_scripts/multi_cloud.bash, docs/source-app/levels/intermediate/level_2_scripts/tr.bash, docs/source-app/workflows/build_command_line_interface/index.rst, docs/source-app/workflows/byoc/aws_cli.rst, docs/source-app/workflows/byoc/aws_console.rst, docs/source-app/workflows/byoc/create_cluster.rst, docs/source-app/workflows/byoc/delete_cluster.rst, docs/source-app/workflows/byoc/index.rst, docs/source-app/workflows/byoc/run_on_cluster.rst, docs/source-app/workflows/index.rst, docs/source-app/workflows/ssh/index.rst, pyproject.toml.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/cli/cmd_apps.py, src/lightning/app/cli/cmd_clusters.py, src/lightning/app/cli/cmd_ssh_keys.py, src/lightning/app/cli/connect/maverick.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_create.py, src/lightning/app/cli/lightning_cli_delete.py, src/lightning/app/cli/lightning_cli_list.py, src/lightning/app/runners/runtime.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_logs.py, src/lightning/app/utilities/cluster_logs.py, src/lightning/app/utilities/logs_socket_api.py, src/lightning/app/utilities/packaging/app_config.py, pyproject.toml.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/cli/cmd_apps.py, src/lightning/app/cli/cmd_clusters.py, src/lightning/app/cli/cmd_ssh_keys.py, src/lightning/app/cli/connect/maverick.py, src/lightning/app/cli/lightning_cli.py, src/lightning/app/cli/lightning_cli_create.py, src/lightning/app/cli/lightning_cli_delete.py, src/lightning/app/cli/lightning_cli_list.py, src/lightning/app/runners/runtime.py, src/lightning/app/testing/testing.py, src/lightning/app/utilities/app_logs.py, src/lightning/app/utilities/cluster_logs.py, src/lightning/app/utilities/logs_socket_api.py, src/lightning/app/utilities/packaging/app_config.py.

🟢 link-check

Check ID	Status
check-md-links / markdown-link-check	success	✅

These checks are required after the changes to src/lightning/app/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

lantiga marked this pull request as draft

July 24, 2023 16:36

lantiga changed the title ~~Remove cluster commands from CLI~~ WIP: Remove cluster commands from CLI

lantiga force-pushed the remove-cluster-commands branch from 157f272 to 6363335 Compare

July 24, 2023 21:55

github-actions bot added pl and removed pl labels

lantiga changed the title ~~WIP: Remove cluster commands from CLI~~ Remove cluster commands from CLI

lantiga marked this pull request as ready for review

July 24, 2023 22:36

awaelchli approved these changes

View reviewed changes

Borda approved these changes

View reviewed changes

mergify bot added the ready label

lantiga added 9 commits

July 26, 2023 11:40


          Remove cluster commands from CLI

7f79a42


          Update docs

f9ea4c6


          Remove index entry

7d1eb65


          Revert accidental conversion to static assets

b935d4a


          Remove reference to deleted file

48dfab3


          Fix highlights

87a2e64


          Fix highlights

356beec


          Remove file

65a8e9d


          Update CHANGELOG

14ef79f

lantiga force-pushed the remove-cluster-commands branch from b8c2ae4 to 14ef79f Compare

July 26, 2023 09:40


          Fix dead link

66b9486

lantiga requested a review from carmocca as a code owner

July 26, 2023 09:49

github-actions bot added the ci label

lantiga and others added 2 commits

July 26, 2023 14:05


          Increase upper bound on state size to reduce flakiness

bc4e429


          Merge branch 'master' into remove-cluster-commands

05d0d2a

lantiga merged commit a7bbbce into master

lantiga deleted the remove-cluster-commands branch

July 27, 2023 22:16

awaelchli mentioned this pull request

Weekly minor patch release 2.0.7 [rebase & merge] #18270

Merged

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Borda Borda approved these changes

awaelchli awaelchli approved these changes

tchaton Awaiting requested review from tchaton tchaton is a code owner

ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

williamFalcon Awaiting requested review from williamFalcon

carmocca Awaiting requested review from carmocca

Labels

app (removed) ci ready