-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requirement to call Fabric.launch()
with DP strategy
#17931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
bug
Something isn't working
strategy: dp (removed in pl)
DataParallel
fabric
lightning.fabric.Fabric
fun
Staff contributions outside working hours - to differentiate from the "community" label
labels
Jun 26, 2023
for more information, see https://pre-commit.ci
…gfix/fabric-dp-launch
carmocca
approved these changes
Jun 26, 2023
Borda
approved these changes
Jun 28, 2023
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jun 30, 2023
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 5d7669a)
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 5d7669a)
Borda
pushed a commit
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 5d7669a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
fabric
lightning.fabric.Fabric
fun
Staff contributions outside working hours - to differentiate from the "community" label
ready
PRs ready to be merged
strategy: dp (removed in pl)
DataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title. When setting
Fabric(strategy="dp")
, it is not required to call.launch()
. And making the call anyways is a no-op.PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @justusschock @awaelchli @carmocca