-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove automatic sharding support with Fabric.run
or fabric.launch(fn)
#17832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
bug
Something isn't working
breaking change
Includes a breaking change
strategy: deepspeed
fabric
lightning.fabric.Fabric
strategy: fsdp
Fully Sharded Data Parallel
labels
Jun 15, 2023
carmocca
changed the title
Remove sharding support with
Remove automatic sharding support with Jun 15, 2023
Fabric.run
or using fabric.launch(fn)
Fabric.run
or fabric.launch(fn)
awaelchli
approved these changes
Jun 15, 2023
Borda
approved these changes
Jun 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #17832 +/- ##
==========================================
+ Coverage 59% 61% +2%
==========================================
Files 839 420 -419
Lines 63788 31914 -31874
==========================================
- Hits 37909 19465 -18444
+ Misses 25879 12449 -13430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
bug
Something isn't working
fabric
lightning.fabric.Fabric
ready
PRs ready to be merged
strategy: deepspeed
strategy: fsdp
Fully Sharded Data Parallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the pattern
fabric.launch(fn)
(required for XLA) is used withfabric.init_module()
and FSDP, the following error appears:Resolves #17462 (comment)
Fixes Lightning-AI/litgpt#154
I didn't find any mention of this functionality in the docs, so they shouldn't need an update.
cc @Borda @justusschock @awaelchli @carmocca