-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable loading full optimizer checkpoints with FSDP #17747
Conversation
Any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leng-yue That's awesome, thank you so much for jumping on this so quickly! I have minor comments. Great work and thanks for extending the test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
Head branch was pushed to by a user without write access
I don't know why some tasks failed after I changed few lines, and there is no error message in azure pipelines... |
Co-authored-by: Adrian Wälchli <[email protected]>
What does this PR do?
Making restoring optimizer states from full checkpoint possible, which is a supplement of #17623.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist