Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log LearningRateMonitor values to Trainer.callback_metrics for EarlyStopping #17626

Merged
merged 10 commits into from
May 18, 2023

Conversation

baskrahmer
Copy link
Contributor

@baskrahmer baskrahmer commented May 14, 2023

…ntegration with EarlyStopping

What does this PR do?

Logs the LearningRateMonitor values to Trainer.callback_metrics such that this is natively accessible by the EarlyStoppingCallback when conditioning on a specific LR key.

Fixes #17449

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 14, 2023
@awaelchli awaelchli added community This PR is from the community feature Is an improvement or enhancement callback: lr monitor labels May 15, 2023
@awaelchli awaelchli added this to the 2.1 milestone May 15, 2023
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!
If you could add a comment in the src/lightning/pytorch/CHANGELOG.md as well, that would be great!

@baskrahmer baskrahmer force-pushed the feature/17449_es_lr_monitor branch from 334d307 to 71e355d Compare May 15, 2023 20:34
src/lightning/pytorch/callbacks/lr_monitor.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label May 17, 2023
@Borda Borda enabled auto-merge (squash) May 17, 2023 17:24
auto-merge was automatically disabled May 18, 2023 16:06

Head branch was pushed to by a user without write access

@Borda Borda changed the title Log LearningRateMonitor values to Trainer.callback_metrics to allow i… Log LearningRateMonitor values to Trainer.callback_metrics for EarlyStopping May 18, 2023
@Borda Borda merged commit 3a68493 into Lightning-AI:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback: lr monitor community This PR is from the community feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EarlyStopping Integration with LearningRateMonitor
4 participants