-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log LearningRateMonitor
values to Trainer.callback_metrics
for EarlyStopping
#17626
Merged
Borda
merged 10 commits into
Lightning-AI:master
from
baskrahmer:feature/17449_es_lr_monitor
May 18, 2023
Merged
Log LearningRateMonitor
values to Trainer.callback_metrics
for EarlyStopping
#17626
Borda
merged 10 commits into
Lightning-AI:master
from
baskrahmer:feature/17449_es_lr_monitor
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baskrahmer
requested review from
awaelchli,
carmocca,
justusschock and
williamFalcon
as code owners
May 14, 2023 13:53
awaelchli
added
community
This PR is from the community
feature
Is an improvement or enhancement
callback: lr monitor
labels
May 15, 2023
awaelchli
reviewed
May 15, 2023
awaelchli
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition!
If you could add a comment in the src/lightning/pytorch/CHANGELOG.md
as well, that would be great!
…ntegration with EarlyStopping
for more information, see https://pre-commit.ci
baskrahmer
force-pushed
the
feature/17449_es_lr_monitor
branch
from
May 15, 2023 20:34
334d307
to
71e355d
Compare
carmocca
approved these changes
May 17, 2023
Borda
approved these changes
May 17, 2023
Co-authored-by: Adrian Wälchli <[email protected]>
auto-merge was automatically disabled
May 18, 2023 16:06
Head branch was pushed to by a user without write access
Borda
changed the title
Log LearningRateMonitor values to Trainer.callback_metrics to allow i…
Log May 18, 2023
LearningRateMonitor
values to Trainer.callback_metrics
for EarlyStopping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback: lr monitor
community
This PR is from the community
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntegration with EarlyStopping
What does this PR do?
Logs the LearningRateMonitor values to Trainer.callback_metrics such that this is natively accessible by the EarlyStoppingCallback when conditioning on a specific LR key.
Fixes #17449
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist