-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from_datasets
to support arbitrary iterables
#17402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
feature
Is an improvement or enhancement
data handling
Generic data-related topic
lightningmodule
pl.LightningModule
pl
Generic label for PyTorch Lightning package
labels
Apr 17, 2023
carmocca
requested review from
williamFalcon,
awaelchli and
justusschock
as code owners
April 17, 2023 15:56
carmocca
added
lightningdatamodule
pl.LightningDataModule
and removed
lightningmodule
pl.LightningModule
labels
Apr 17, 2023
carmocca
commented
Apr 17, 2023
awaelchli
approved these changes
Apr 17, 2023
Borda
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data handling
Generic data-related topic
feature
Is an improvement or enhancement
lightningdatamodule
pl.LightningDataModule
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #16015 (comment)
cc @Borda @justusschock @awaelchli @carmocca