Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPU] Add support for PJRT from PyTorch/XLA 2.0 #17352

Merged
merged 56 commits into from
Apr 18, 2023

Conversation

Liyang90
Copy link
Contributor

@Liyang90 Liyang90 commented Apr 12, 2023

What does this PR do?

Fixes #\17350

To use PJRT with XLAStrategy, simply set PJRT_DEVICE env var, e.g. PJRT_DEVICE=TPU.

To run on a TPU Pod with PJRT, xla_dist is not needed anymore. You can directly issue the same command to all TPU workers:

gcloud compute tpus tpu-vm ssh <TPU name> --zone=<TPU zone> --project=<project name> --worker=all --command="PJRT_DEVICE=TPU python3 <your script>"

For more details on PJRT, please visit: https://github.com/pytorch/xla/blob/r2.0/docs/pjrt.md

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@Liyang90 Liyang90 changed the title Add support for PJRT in PyTorch/XLA 2.0 [TPU]Add support for PJRT in PyTorch/XLA 2.0 Apr 12, 2023
@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Apr 12, 2023
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make also the TPU as experimental as it uses XLA experimental

@Liyang90 Liyang90 changed the title [TPU]Add support for PJRT in PyTorch/XLA 2.0 [TPU]Add support for PJRT from PyTorch/XLA 2.0 Apr 12, 2023
@Liyang90
Copy link
Contributor Author

@will-cromar for review

@carmocca carmocca changed the title [TPU]Add support for PJRT from PyTorch/XLA 2.0 [TPU] Add support for PJRT from PyTorch/XLA 2.0 Apr 12, 2023
@awaelchli awaelchli added feature Is an improvement or enhancement strategy: xla labels Apr 12, 2023
@awaelchli awaelchli added this to the 2.1 milestone Apr 12, 2023
@awaelchli awaelchli added the community This PR is from the community label Apr 12, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 17, 2023
@carmocca carmocca merged commit 4772639 into Lightning-AI:master Apr 18, 2023
@Liyang90 Liyang90 deleted the xla_pjrt_debug branch April 26, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration community This PR is from the community fabric lightning.fabric.Fabric feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: xla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PyTorch/XLA PJRT for XLAStrategy
6 participants