-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TPU] Add support for PJRT from PyTorch/XLA 2.0 #17352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liyang90
requested review from
awaelchli,
carmocca,
justusschock and
williamFalcon
as code owners
April 12, 2023 18:33
Liyang90
changed the title
Add support for PJRT in PyTorch/XLA 2.0
[TPU]Add support for PJRT in PyTorch/XLA 2.0
Apr 12, 2023
github-actions
bot
added
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
labels
Apr 12, 2023
for more information, see https://pre-commit.ci
Liyang90
commented
Apr 12, 2023
Liyang90
commented
Apr 12, 2023
Liyang90
commented
Apr 12, 2023
Liyang90
commented
Apr 12, 2023
Liyang90
commented
Apr 12, 2023
Liyang90
commented
Apr 12, 2023
Borda
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets make also the TPU as experimental as it uses XLA experimental
Liyang90
changed the title
[TPU]Add support for PJRT in PyTorch/XLA 2.0
[TPU]Add support for PJRT from PyTorch/XLA 2.0
Apr 12, 2023
@will-cromar for review |
carmocca
changed the title
[TPU]Add support for PJRT from PyTorch/XLA 2.0
[TPU] Add support for PJRT from PyTorch/XLA 2.0
Apr 12, 2023
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Apr 17, 2023
carmocca
approved these changes
Apr 18, 2023
awaelchli
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #\17350
To use PJRT with XLAStrategy, simply set
PJRT_DEVICE
env var, e.g.PJRT_DEVICE=TPU
.To run on a TPU Pod with PJRT,
xla_dist
is not needed anymore. You can directly issue the same command to all TPU workers:For more details on PJRT, please visit: https://github.com/pytorch/xla/blob/r2.0/docs/pjrt.md
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist