Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPU] Remove error check for IterableDatasets #17331

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

gkroiz
Copy link
Contributor

@gkroiz gkroiz commented Apr 11, 2023

What does this PR do?

Fixes #17321

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Apr 11, 2023
@carmocca carmocca added feature Is an improvement or enhancement accelerator: tpu Tensor Processing Unit labels Apr 11, 2023
@carmocca carmocca added this to the 2.1 milestone Apr 11, 2023
@carmocca carmocca added the community This PR is from the community label Apr 11, 2023
@carmocca carmocca self-assigned this Apr 11, 2023
@carmocca carmocca changed the title removing error check on TPUs for IterableDatasets [TPU] Remove error check for IterableDatasets Apr 11, 2023
@mergify mergify bot added the ready PRs ready to be merged label Apr 11, 2023
@awaelchli awaelchli enabled auto-merge (squash) April 11, 2023 20:15
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #17331 (5cb313e) into master (0c02c44) will increase coverage by 17%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #17331     +/-   ##
=========================================
+ Coverage      43%      59%    +17%     
=========================================
  Files         430      410     -20     
  Lines       31603    31368    -235     
=========================================
+ Hits        13459    18562   +5103     
+ Misses      18144    12806   -5338     

@awaelchli awaelchli merged commit 7b8fd85 into Lightning-AI:master Apr 11, 2023
@gkroiz gkroiz deleted the tpu-iterable-datasets branch April 13, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit community This PR is from the community fabric lightning.fabric.Fabric feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iterable Datasets work with TPUs
3 participants