-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified setup of optimizers in FSDP #17309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
feature
Is an improvement or enhancement
strategy: fsdp
Fully Sharded Data Parallel
pl
Generic label for PyTorch Lightning package
fun
Staff contributions outside working hours - to differentiate from the "community" label
labels
Apr 9, 2023
for more information, see https://pre-commit.ci
…orch' into feature/fsdp-use-orig-params-pytorch
awaelchli
requested review from
carmocca,
justusschock,
williamFalcon,
edenlightning,
lantiga and
Borda
as code owners
April 11, 2023 04:39
Borda
approved these changes
Apr 11, 2023
carmocca
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Is an improvement or enhancement
fun
Staff contributions outside working hours - to differentiate from the "community" label
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: fsdp
Fully Sharded Data Parallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves a limitation in FSDP for users of PyTorch 2.0+. Previously, to use FSDP you had to make code modifications. In particular, you had to write
optimizer = Adam(self.trainer.model.parameters)
instead of justoptimizer = Adam(self.parameters)
. This can be avoided by enablinguse_orig_params
in the FSDP wrapper. This PR enables this for users of PyTorch >= 2.0 automatically. This also enables multiple parameter groups which was previously not possible.This PR goes alongside the equivalent change in Fabric: #17305
cc @Borda @awaelchli @carmocca