Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the is_picklable function more robust #17270

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Make the is_picklable function more robust #17270

merged 5 commits into from
Apr 6, 2023

Conversation

leng-yue
Copy link
Contributor

@leng-yue leng-yue commented Apr 4, 2023 •
edited
Loading

What does this PR do?

Fixes #17269

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 4, 2023
@leng-yue leng-yue marked this pull request as ready for review April 4, 2023 00:41
awaelchli
awaelchli approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you add an entry in the changelog in src/lightning/pytorch/changelog.md

@awaelchli awaelchli added the bug Something isn't working label Apr 4, 2023
@awaelchli awaelchli added this to the 2.0.x milestone Apr 4, 2023
@awaelchli awaelchli added the community This PR is from the community label Apr 4, 2023
@awaelchli awaelchli changed the title Fix #17269: TypeError: cannot pickle '_thread.lock' object Make the is_picklable function more robust Apr 4, 2023
@mergify mergify bot added the ready PRs ready to be merged label Apr 4, 2023
@leng-yue
Copy link
Contributor Author

leng-yue commented Apr 5, 2023

Sure, I will do that :)

@github-actions github-actions bot added the ci Continuous Integration label Apr 5, 2023
@awaelchli awaelchli enabled auto-merge (squash) April 5, 2023 19:29
@awaelchli awaelchli disabled auto-merge April 5, 2023 19:29
@github-actions github-actions bot removed the ci Continuous Integration label Apr 5, 2023
@awaelchli awaelchli enabled auto-merge (squash) April 5, 2023 19:29
@leng-yue
Copy link
Contributor Author

leng-yue commented Apr 6, 2023

Seems like https://lightning.ai/docs/pytorch/latest/governance.html is no longer available, should I update the branch?

@awaelchli
Copy link
Contributor

This issue was resolved and we should be able to merge this shortly.

@awaelchli awaelchli merged commit fd4697c into Lightning-AI:master Apr 6, 2023
@leng-yue leng-yue deleted the patch-1 branch April 6, 2023 23:12
awaelchli pushed a commit that referenced this pull request Apr 6, 2023
@leng-yue @awaelchli
Make the is_picklable function more robust (#17270)
cccf74c
lexierule pushed a commit that referenced this pull request Apr 11, 2023
@leng-yue @lexierule
Make the is_picklable function more robust (#17270)
e4cc968
Borda pushed a commit that referenced this pull request Apr 24, 2023
@leng-yue @Borda
Make the is_picklable function more robust (#17270)
6493c76 
(cherry picked from commit fd4697c)
Borda pushed a commit that referenced this pull request Apr 24, 2023
@leng-yue @Borda
Make the is_picklable function more robust (#17270)
da383dc 
(cherry picked from commit fd4697c)
lantiga pushed a commit that referenced this pull request Apr 26, 2023
@leng-yue @lantiga
Make the is_picklable function more robust (#17270)
3c051ae 
(cherry picked from commit fd4697c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
bug Something isn't working community This PR is from the community pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.

TypeError: cannot pickle '_thread.lock' object
4 participants
@leng-yue @awaelchli @Borda @justusschock