Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loggers): add best and latest aliases to wandb artifact in WandbLogger #17121

Merged
merged 9 commits into from
Mar 20, 2023
Merged

fix(loggers): add best and latest aliases to wandb artifact in WandbLogger #17121

merged 9 commits into from
Mar 20, 2023

Conversation

parambharat
Copy link
Contributor

@parambharat parambharat commented Mar 17, 2023 •
edited
Loading

What does this PR do?

Fixes #16979
Logs the best and latest tags when model artifacts are logged with lightning.pytorch.callbacks.ModelCheckpoint

Here's a sample wandb workspace that has the corresponding artifacts.
Here's a colab to reproduce the runs in the workspace above.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

fix(integrations): add best and latest tags to wandb artifact
6cce1a0 
fixes Lightning-AI#16979
logs the `best` and `latest` tags when model artifacts are logged with `lightning.pytorch.callbacks.ModelCheckpoint`
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 17, 2023
@parambharat parambharat mentioned this pull request Mar 17, 2023
Closed
@parambharat parambharat marked this pull request as ready for review March 17, 2023 08:05
@parambharat parambharat changed the title fix(loggers): add best and latest tags to wandb artifact in WandbLogger fix(loggers): add best and latest aliases to wandb artifact in WandbLogger Mar 17, 2023
@awaelchli awaelchli added logger: wandb Weights & Biases community This PR is from the community labels Mar 17, 2023
@awaelchli awaelchli modified the milestones: 2.0.x, v1.9.x Mar 17, 2023
@awaelchli awaelchli self-assigned this Mar 17, 2023
@awaelchli awaelchli added the bug Something isn't working label Mar 17, 2023
@mergify mergify bot added the ready PRs ready to be merged label Mar 17, 2023
@carmocca carmocca enabled auto-merge (squash) March 17, 2023 14:05
@awaelchli
Copy link
Contributor

Hmm, the bot is not triggering the merge 🤔

@pre-commit-ci pre-commit-ci bot requested a review from lantiga as a code owner March 18, 2023 01:10
@carmocca carmocca mentioned this pull request Mar 18, 2023
Merged
7 tasks
@mergify mergify bot removed the ready PRs ready to be merged label Mar 20, 2023
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Mar 20, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Mar 20, 2023
@carmocca carmocca merged commit 7bc2a65 into Lightning-AI:master Mar 20, 2023
carmocca pushed a commit that referenced this pull request Mar 21, 2023
@parambharat @awaelchli @carmocca
fix(loggers): add best and latest aliases to wandb artifact in `W…
43d7184 
…andbLogger` (#17121)

Co-authored-by: awaelchli <[email protected]>
lantiga pushed a commit that referenced this pull request Mar 30, 2023
@parambharat @awaelchli @lantiga
fix(loggers): add best and latest aliases to wandb artifact in `W…
626b3ac 
…andbLogger` (#17121)

Co-authored-by: awaelchli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees

@awaelchli awaelchli

Labels
bug Something isn't working community This PR is from the community logger: wandb Weights & Biases pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.9.x
Development

Successfully merging this pull request may close these issues.

WandbLogger model artifacts do not have best aliases when using save_top_k> 0
4 participants
@parambharat @awaelchli @carmocca @Borda