-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort Trainer arguments based on importance #17022
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
williamFalcon,
tchaton and
carmocca
as code owners
March 10, 2023 01:20
awaelchli
commented
Mar 10, 2023
carmocca
approved these changes
Mar 10, 2023
awaelchli
commented
Mar 10, 2023
tests/tests_pytorch/callbacks/progress/test_rich_progress_bar.py
Outdated
Show resolved
Hide resolved
justusschock
approved these changes
Mar 10, 2023
this is a breaking change so a user can't pass just an argument
not randomly but with respect to minimizing breaking changes.... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
code quality
docs
Documentation related
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
trainer: argument
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I propose to organize the Trainer's arguments based on importance/usage frequency. This is just my take on it, please make suggestions. Alternatively, they could also be grouped by function.
Before, the arguments were arranged randomly.
cc @Borda @justusschock @awaelchli