Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_wrapped utility function for Fabric #16953

Merged
merged 12 commits into from
Mar 14, 2023

Conversation

Atharva-Phatak
Copy link
Contributor

@Atharva-Phatak Atharva-Phatak commented Mar 5, 2023

What does this PR do?

Method to check whether a Fabric model was set up already #16484

Fixes #16484

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Mar 5, 2023
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Merging #16953 (576a5e3) into master (a8c4d1f) will decrease coverage by 23%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #16953     +/-   ##
=========================================
- Coverage      82%      59%    -23%     
=========================================
  Files         438      413     -25     
  Lines       31756    31459    -297     
=========================================
- Hits        25994    18660   -7334     
- Misses       5762    12799   +7037     

@awaelchli awaelchli changed the title Fabric fix Add is_wrapped utility function for Fabric Mar 5, 2023
@awaelchli awaelchli added the feature Is an improvement or enhancement label Mar 5, 2023
@awaelchli awaelchli added this to the 2.0 milestone Mar 5, 2023
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good already. Added a few comments.
Don't forget to add a changelog entry :)

src/lightning/fabric/fabric.py Outdated Show resolved Hide resolved
src/lightning/fabric/fabric.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added the community This PR is from the community label Mar 8, 2023
@carmocca carmocca modified the milestones: 2.0, 2.1 Mar 13, 2023
@awaelchli awaelchli self-assigned this Mar 14, 2023
@awaelchli awaelchli added the ready PRs ready to be merged label Mar 14, 2023
src/lightning/fabric/wrappers.py Outdated Show resolved Hide resolved
@awaelchli awaelchli enabled auto-merge (squash) March 14, 2023 09:45
@awaelchli awaelchli merged commit ea708da into Lightning-AI:master Mar 14, 2023
@awaelchli awaelchli modified the milestones: 2.1, 2.0 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community fabric lightning.fabric.Fabric feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method to check whether a Fabric model was set up already
5 participants