-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_wrapped
utility function for Fabric
#16953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atharva-Phatak
requested review from
awaelchli,
carmocca and
justusschock
as code owners
March 5, 2023 03:50
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #16953 +/- ##
=========================================
- Coverage 82% 59% -23%
=========================================
Files 438 413 -25
Lines 31756 31459 -297
=========================================
- Hits 25994 18660 -7334
- Misses 5762 12799 +7037 |
justusschock
reviewed
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already. Added a few comments.
Don't forget to add a changelog entry :)
awaelchli
requested review from
edenlightning,
lantiga and
Borda
as code owners
March 14, 2023 01:34
awaelchli
approved these changes
Mar 14, 2023
carmocca
approved these changes
Mar 14, 2023
Borda
approved these changes
Mar 14, 2023
Co-authored-by: Carlos Mocholí <[email protected]>
justusschock
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Method to check whether a Fabric model was set up already #16484
Fixes #16484
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist