-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max_size
mode to CombinedLoader
#16939
Merged
carmocca
merged 7 commits into
Lightning-AI:master
from
janpawlowskiof:feature/16917_add_max_size_mode_to_combined_loader
Mar 6, 2023
Merged
Add max_size
mode to CombinedLoader
#16939
carmocca
merged 7 commits into
Lightning-AI:master
from
janpawlowskiof:feature/16917_add_max_size_mode_to_combined_loader
Mar 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpawlowskiof
requested review from
awaelchli,
carmocca,
justusschock and
williamFalcon
as code owners
March 3, 2023 12:33
awaelchli
added
feature
Is an improvement or enhancement
data handling
Generic data-related topic
community
This PR is from the community
labels
Mar 3, 2023
awaelchli
approved these changes
Mar 3, 2023
There are some unrelated tests failing in the CI (red crosses). Don't worry about that, this will be resolved soon. |
carmocca
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
This PR is from the community
data handling
Generic data-related topic
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
max_size
mode support to CombinedLoader, which works very much likemax_size_cycle
, but it returnsNone
s instead of cycling through exhausted iterables.Discussed in #16917
Also includes added tests for NamedTuples support in CombinedLoader, which seemed to have been missing. Hopefully this does not break to PR does only one thing rule.
Also: First time contributing, yay!
Before submitting
PR review
Reviewer checklist