-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strategy="auto" support on the 1.9.x branch #16916
Conversation
⛈️ Required checks status: Has failure 🔴
Groups summary🔴 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Azure HPU
These checks are required after the changes to 🟡 pytorch_lightning: Azure IPU
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to 🔴 link-check
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/stable #16916 +/- ##
=================================================
- Coverage 82% 62% -20%
=================================================
Files 474 435 -39
Lines 35160 34979 -181
=================================================
- Hits 28685 21654 -7031
- Misses 6475 13325 +6850 |
3569d5e
to
c02898e
Compare
What does this PR do?
This adds support for passing strategy="auto" to Fabric or Trainer. This is essentially the same as the previous strategy=None behavior, but will favor ddp over ddp_spawn when possible. strategy=None is still the default.
cc @Borda @tchaton @carmocca @justusschock @awaelchli