import neptune instead of import neptune.new

[wouterzwerink]

What does this PR do?

Updates the importing of neptune according to https://docs.neptune.ai/setup/neptune-client_1-0_release_changes/
This probably breaks NeptuneLogger with neptune-client<1.0.0. Should neptune-client>=1.0.0 be added as a requirement?

Fixes #16887

Before submitting

• Was this discussed/agreed via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

[carmocca]

cc @Blaizzy for review too

[Borda]

cc @Blaizzy for review too

lgtm :) btw, for visibility: #16761

[wouterzwerink]

I reverted the conda install instructions because they do not work yet.

cc @Blaizzy for review too

lgtm :) btw, for visibility: #16761

Ah nice, my bad for not finding it! I must have only checked the open PRs.

[Blaizzy]

Hi @wouterzwerink and @carmocca

Thanks for the initiative!

However, this PR solves part of the problem but not all.

There are a few more issues precisely:

• Users still using the legacy client(<=1.0.0) will have their workflows broken.
• The new client no longer supports automatically converting unsupported data types to strings. (Docs: https://docs.neptune.ai/api/utils/#stringify_unsupported)

We are preparing a PR to address the breaking changes and ensure backward compatibility.

So, could you please revert this PR?

Here is the draft PR we have been working on for a few weeks:
https://github.com/Lightning-AI/lightning/pull/16761/files

[wouterzwerink]

@Blaizzy sure, reverting in #16898.

[carmocca]

@Blaizzy you can incorporate those changes and backwards compatibility in #16761 after rebasing this PR's changes. Without needing to revert

[Blaizzy]

@carmocca sure, no problem!

[Blaizzy]

Thanks, guys!

I really appreciate the initiative, @wouterzwerink!