Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fsspec paths for CSVLoggers #16880

Merged
merged 13 commits into from
Mar 2, 2023

Conversation

leoleoasd
Copy link
Contributor

What does this PR do?

Add support for fsspec paths for CSVLoggers

Fixes #16196

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #16880 (ff697c7) into master (70b257c) will decrease coverage by 23%.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #16880     +/-   ##
=========================================
- Coverage      82%      59%    -23%     
=========================================
  Files         436      412     -24     
  Lines       31561    31270    -291     
=========================================
- Hits        25799    18523   -7276     
- Misses       5762    12747   +6985     

src/lightning/fabric/loggers/csv_logs.py Outdated Show resolved Hide resolved
src/lightning/fabric/CHANGELOG.md Outdated Show resolved Hide resolved
tests/tests_pytorch/loggers/test_csv.py Outdated Show resolved Hide resolved
@carmocca carmocca added logger: csv community This PR is from the community labels Feb 27, 2023
@carmocca carmocca added the feature Is an improvement or enhancement label Feb 27, 2023
@carmocca carmocca modified the milestones: future, 2.0 Feb 27, 2023
@mergify mergify bot added the ready PRs ready to be merged label Feb 27, 2023
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Feb 27, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 28, 2023
@carmocca carmocca self-assigned this Feb 28, 2023
@carmocca carmocca enabled auto-merge (squash) March 1, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community fabric lightning.fabric.Fabric feature Is an improvement or enhancement logger: csv pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSVLogger fails if save_dir is an s3 path
6 participants