-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fsspec paths for CSVLoggers #16880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoleoasd
requested review from
awaelchli,
carmocca,
justusschock and
williamFalcon
as code owners
February 27, 2023 08:16
github-actions
bot
added
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
labels
Feb 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #16880 +/- ##
=========================================
- Coverage 82% 59% -23%
=========================================
Files 436 412 -24
Lines 31561 31270 -291
=========================================
- Hits 25799 18523 -7276
- Misses 5762 12747 +6985 |
justusschock
approved these changes
Feb 27, 2023
carmocca
reviewed
Feb 27, 2023
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca
approved these changes
Feb 27, 2023
awaelchli
approved these changes
Feb 27, 2023
carmocca
reviewed
Feb 28, 2023
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Feb 28, 2023
ELind77
reviewed
Feb 28, 2023
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for fsspec paths for CSVLoggers
Fixes #16196
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist