-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for hanging issue on TPU Pod #16844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liyang90
requested review from
awaelchli,
carmocca,
justusschock and
williamFalcon
as code owners
February 22, 2023 19:31
github-actions
bot
added
fabric
lightning.fabric.Fabric
pl
Generic label for PyTorch Lightning package
labels
Feb 22, 2023
for more information, see https://pre-commit.ci
carmocca
reviewed
Feb 22, 2023
carmocca
added
bug
Something isn't working
accelerator: tpu
Tensor Processing Unit
labels
Feb 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #16844 +/- ##
=========================================
- Coverage 82% 59% -22%
=========================================
Files 437 413 -24
Lines 31528 31231 -297
=========================================
- Hits 25777 18524 -7253
- Misses 5751 12707 +6956 |
carmocca
approved these changes
Feb 23, 2023
awaelchli
approved these changes
Feb 23, 2023
carmocca
added a commit
that referenced
this pull request
Feb 27, 2023
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Feb 28, 2023
Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #16843
Letting
XLAEnvironment
providestrategy.local_rank
to the spawned processes, instead of usingprocess_id
. Avoid usingstrategy.local_rank
outside of the spawned processes, as the XLA has not set that up.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
@JackCaoG @steventk-g @will-cromar