Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hanging issue on TPU Pod #16844

Merged
merged 8 commits into from
Feb 23, 2023
Merged

Conversation

Liyang90
Copy link
Contributor

What does this PR do?

Fixes #16843

Letting XLAEnvironment provide strategy.local_rank to the spawned processes, instead of using process_id. Avoid using strategy.local_rank outside of the spawned processes, as the XLA has not set that up.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@JackCaoG @steventk-g @will-cromar

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Feb 22, 2023
@carmocca carmocca added bug Something isn't working accelerator: tpu Tensor Processing Unit labels Feb 22, 2023
@carmocca carmocca added this to the v1.9.x milestone Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #16844 (1b55d33) into master (235e692) will decrease coverage by 22%.
The diff coverage is 27%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #16844     +/-   ##
=========================================
- Coverage      82%      59%    -22%     
=========================================
  Files         437      413     -24     
  Lines       31528    31231    -297     
=========================================
- Hits        25777    18524   -7253     
- Misses       5751    12707   +6956     

@mergify mergify bot added the ready PRs ready to be merged label Feb 23, 2023
@carmocca carmocca added the community This PR is from the community label Feb 23, 2023
@carmocca carmocca self-assigned this Feb 23, 2023
@carmocca carmocca merged commit 1913913 into Lightning-AI:master Feb 23, 2023
carmocca added a commit that referenced this pull request Feb 27, 2023
lexierule pushed a commit that referenced this pull request Feb 28, 2023
@Liyang90 Liyang90 deleted the tpu_node_fix branch March 11, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working community This PR is from the community fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main process hanging on TPU Pod
3 participants