Fabric: auto default #16842

carmocca · 2023-02-22T17:08:31Z

What does this PR do?

cc @justusschock @awaelchli @Borda @carmocca

github-actions · 2023-02-22T18:39:44Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to docs/source-pytorch/fabric/fundamentals/accelerators.rst.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, tests/tests_fabric/conftest.py, tests/tests_fabric/plugins/precision/test_amp_integration.py, tests/tests_fabric/test_connector.py, tests/tests_fabric/test_parity.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py, tests/tests_fabric/conftest.py, tests/tests_fabric/plugins/precision/test_amp_integration.py, tests/tests_fabric/test_connector.py, tests/tests_fabric/test_parity.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/fabric/connector.py, src/lightning/fabric/fabric.py.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning/fabric/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

codecov · 2023-02-22T19:08:17Z

Codecov Report

Merging #16842 (35ef37e) into master (235e692) will decrease coverage by 22%.
The diff coverage is 100%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #16842     +/-   ##
=========================================
- Coverage      82%      59%    -22%     
=========================================
  Files         437      413     -24     
  Lines       31528    31228    -300     
=========================================
- Hits        25777    18510   -7267     
- Misses       5751    12718   +6967

tests/tests_fabric/plugins/precision/test_amp_integration.py

docs/source-pytorch/fabric/fundamentals/launch.rst

Fabric: auto default

d573b32

carmocca added refactor breaking change Includes a breaking change fabric lightning.fabric.Fabric labels Feb 22, 2023

carmocca added this to the 2.0 milestone Feb 22, 2023

carmocca self-assigned this Feb 22, 2023

carmocca added 5 commits February 22, 2023 18:35

Fix tests

6df39e4

Auto test

a7cf195

Master fix

5a8b038

CHANGELOG

76a9d7f

Failing test

276f0a8

github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 22, 2023

carmocca marked this pull request as ready for review February 22, 2023 18:39

carmocca requested review from awaelchli and justusschock as code owners February 22, 2023 18:39

carmocca added 3 commits February 22, 2023 19:44

Mock torch.device during mps check

2a0dd78

Only 1.12

8ccc2e8

TPU fix

bf65534

carmocca added 3 commits February 23, 2023 01:01

Simpler

2ec8ac2

Messaging

7d26de8

Merge branch 'master' into fabric/auto

2e27c82

github-actions bot removed the pl Generic label for PyTorch Lightning package label Feb 23, 2023

Docs

648a822

carmocca requested review from edenlightning, lantiga and Borda as code owners February 23, 2023 00:33

github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 23, 2023

Update exception

1221b1c

awaelchli reviewed Feb 23, 2023

View reviewed changes

tests/tests_fabric/plugins/precision/test_amp_integration.py Show resolved Hide resolved

docs/source-pytorch/fabric/fundamentals/launch.rst Outdated Show resolved Hide resolved

Revert launch table

35ef37e

awaelchli approved these changes Feb 23, 2023

View reviewed changes

carmocca mentioned this pull request Feb 23, 2023

Fabric mixed precision test fails with multiple CUDA devices #16852

Closed

Borda approved these changes Feb 23, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Feb 23, 2023

carmocca enabled auto-merge (squash) February 23, 2023 13:45

carmocca merged commit d486f94 into master Feb 23, 2023

carmocca deleted the fabric/auto branch February 23, 2023 13:45

This was referenced Feb 23, 2023

Trainer: auto default #16847

Merged

Fix tests on single-GPU machine #16911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fabric: auto default #16842

Fabric: auto default #16842

carmocca commented Feb 22, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 22, 2023 •

edited

Loading

codecov bot commented Feb 22, 2023 •

edited

Loading

Fabric: auto default #16842

Fabric: auto default #16842

Conversation

carmocca commented Feb 22, 2023 • edited by github-actions bot Loading

What does this PR do?

github-actions bot commented Feb 22, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

codecov bot commented Feb 22, 2023 • edited Loading

Codecov Report

carmocca commented Feb 22, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 22, 2023 •

edited

Loading

codecov bot commented Feb 22, 2023 •

edited

Loading