Incorporate pytorch's fixes in device_count_nvml #16795

awaelchli · 2023-02-17T15:22:57Z

What does this PR do?

Adopts the changes/fixes from pytorch/pytorch@e7e51b3

Fixes #16590

cc @Borda @carmocca @justusschock @awaelchli

for more information, see https://pre-commit.ci

github-actions · 2023-02-17T16:57:22Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, tests/tests_fabric/plugins/collectives/test_torch_collective.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py, tests/tests_fabric/plugins/collectives/test_torch_collective.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/fabric/accelerators/cuda.py.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning/fabric/CHANGELOG.md, src/lightning/pytorch/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

src/lightning/fabric/accelerators/cuda.py

codecov · 2023-02-17T17:17:36Z

Codecov Report

Merging #16795 (ea2ad4f) into master (36c39ea) will decrease coverage by 23%.
The diff coverage is 13%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #16795     +/-   ##
=========================================
- Coverage      82%      59%    -23%     
=========================================
  Files         437      413     -24     
  Lines       31587    31369    -218     
=========================================
- Hits        25827    18581   -7246     
- Misses       5760    12788   +7028

Co-authored-by: Carlos Mocholí <[email protected]>

for more information, see https://pre-commit.ci

port changes from pytorch upstream

8a53169

awaelchli added bug Something isn't working 3rd party Related to a 3rd-party accelerator: cuda Compute Unified Device Architecture GPU labels Feb 17, 2023

awaelchli added this to the v1.9.x milestone Feb 17, 2023

github-actions bot added the fabric lightning.fabric.Fabric label Feb 17, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

44fb060

for more information, see https://pre-commit.ci

awaelchli marked this pull request as ready for review February 17, 2023 16:56

awaelchli requested review from carmocca and justusschock as code owners February 17, 2023 16:56

changelog

ee63807

awaelchli requested a review from williamFalcon as a code owner February 17, 2023 17:00

github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 17, 2023

carmocca reviewed Feb 17, 2023

View reviewed changes

justusschock approved these changes Feb 17, 2023

View reviewed changes

mergify bot added the has conflicts label Feb 20, 2023

Merge branch 'master' into bugfix/pytorch-device-count-nvml

2816ea1

mergify bot removed the has conflicts label Feb 27, 2023

awaelchli and others added 2 commits February 27, 2023 08:26

Apply suggestions from code review

f905065

Co-authored-by: Carlos Mocholí <[email protected]>

carlos

f4cf082

awaelchli requested a review from carmocca February 27, 2023 13:30

[pre-commit.ci] auto fixes from pre-commit.com hooks

bc05634

for more information, see https://pre-commit.ci

carmocca approved these changes Feb 27, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Feb 27, 2023

Merge branch 'master' into bugfix/pytorch-device-count-nvml

4bef3ba

awaelchli enabled auto-merge (squash) February 27, 2023 16:54

skip windows

ea2ad4f

awaelchli merged commit e3efbaa into master Feb 27, 2023

awaelchli deleted the bugfix/pytorch-device-count-nvml branch February 27, 2023 18:07

awaelchli added a commit that referenced this pull request Feb 27, 2023

Incorporate pytorch's fixes in device_count_nvml #16795

7699bad

awaelchli mentioned this pull request Feb 27, 2023

CUDAAccelerator can not run on your system since the accelerator is not available. #16590

Closed

lexierule pushed a commit that referenced this pull request Feb 28, 2023

Incorporate pytorch's fixes in device_count_nvml #16795

b0c7908

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incorporate pytorch's fixes in device_count_nvml #16795

Incorporate pytorch's fixes in device_count_nvml #16795

awaelchli commented Feb 17, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 17, 2023 •

edited

Loading

codecov bot commented Feb 17, 2023 •

edited

Loading

Incorporate pytorch's fixes in device_count_nvml #16795

Incorporate pytorch's fixes in device_count_nvml #16795

Conversation

awaelchli commented Feb 17, 2023 • edited by github-actions bot Loading

What does this PR do?

github-actions bot commented Feb 17, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

codecov bot commented Feb 17, 2023 • edited Loading

Codecov Report

awaelchli commented Feb 17, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 17, 2023 •

edited

Loading

codecov bot commented Feb 17, 2023 •

edited

Loading