Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header_style argument to RichModelSummary callback #16788

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Add header_style argument to RichModelSummary callback #16788

merged 3 commits into from
Apr 18, 2023

Conversation

rusmux
Copy link
Contributor

@rusmux rusmux commented Feb 16, 2023

What does this PR do?

Fixes #15683

Add a color option for the table header of the RichModelSummary callback.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 16, 2023
@Borda Borda changed the title Add header_style argument to RichModelSummary callback Add header_style argument to RichModelSummary callback Feb 17, 2023
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add entry to changelog

@rusmux
Copy link
Contributor Author

rusmux commented Feb 17, 2023

@Borda I amended the commit to include entry in the changelog

@awaelchli awaelchli added the community This PR is from the community label Feb 17, 2023
@awaelchli awaelchli added this to the 2.0 milestone Feb 17, 2023
@awaelchli awaelchli added the feature Is an improvement or enhancement label Feb 17, 2023
@mergify mergify bot added the ready PRs ready to be merged label Feb 17, 2023
@carmocca carmocca self-assigned this Feb 20, 2023
@mergify mergify bot removed the ready PRs ready to be merged label Feb 20, 2023
@carmocca carmocca removed this from the 2.0 milestone Mar 2, 2023
@carmocca carmocca removed their assignment Mar 9, 2023
@Borda
Copy link
Member

Borda commented Apr 14, 2023

@rusmux how is it going here? 🐰

@mergify mergify bot removed the has conflicts label Apr 14, 2023
@rusmux
Copy link
Contributor Author

rusmux commented Apr 15, 2023

@rusmux how is it going here? 🐰

Oh, I just saw @carmocca self-assigned it. But he removed it, so I'll look into it now.

@rusmux rusmux requested a review from carmocca April 16, 2023 10:23
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Apr 16, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 16, 2023
@Borda Borda merged commit 7312b3f into Lightning-AI:master Apr 18, 2023
@rusmux rusmux deleted the dev branch April 18, 2023 12:03
@awaelchli awaelchli added this to the 2.1 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color option for RichModelSummary
4 participants