Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Add support for private data #16738

Merged
merged 37 commits into from
Feb 14, 2023
Merged

[App] Add support for private data #16738

merged 37 commits into from
Feb 14, 2023

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 13, 2023 •
edited by github-actions bot
Loading

What does this PR do?

This PR enables to create private data connection to s3.

LIGHTNING_CLOUD_URL=http://localhost:9800/ lightning connect data private_bucket_2 --region us-east-1 --source s3://private-data-demo --secret_arn_name role

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Feb 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success ✅
app-pytest (macOS-11, lightning, 3.8, oldest) success ✅
app-pytest (macOS-11, app, 3.9, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success ✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success ✅
app-pytest (ubuntu-20.04, app, 3.9, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, latest) success ✅
app-pytest (windows-2022, lightning, 3.8, oldest) success ✅
app-pytest (windows-2022, app, 3.8, latest) success ✅

These checks are required after the changes to src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/connect/data.py, tests/tests_app/cli/test_connect_data.py, requirements/app/base.txt.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success ✅
app-examples (macOS-11, lightning, 3.9, oldest) success ✅
app-examples (macOS-11, app, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, latest) success ✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success ✅
app-examples (ubuntu-20.04, app, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, latest) success ✅
app-examples (windows-2022, lightning, 3.9, oldest) success ✅
app-examples (windows-2022, app, 3.9, latest) success ✅

These checks are required after the changes to src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/connect/data.py, requirements/app/base.txt.

🟢 lightning_app: Azure
Check ID Status
App.cloud-e2e success ✅

These checks are required after the changes to src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/connect/data.py, requirements/app/base.txt.

🟢 lightning_app: Docs
Check ID Status
make-doctest (lightning) success ✅
make-html (lightning) success ✅

These checks are required after the changes to src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/connect/data.py, requirements/app/base.txt.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to requirements/app/base.txt, src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/connect/data.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.8) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.8) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.8) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.8) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.8) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.8) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.8) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.8) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.8) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.8) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.8) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.8) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.8) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.8) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/lightning/app/cli/commands/ls.py, src/lightning/app/cli/connect/data.py, requirements/app/base.txt.

🟢 link-check
Check ID Status
markdown-link-check success ✅

These checks are required after the changes to src/lightning/app/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@tchaton tchaton requested a review from Borda as a code owner February 13, 2023 08:57
@tchaton tchaton self-assigned this Feb 13, 2023
@mergify mergify bot removed the has conflicts label Feb 13, 2023
@tchaton tchaton enabled auto-merge (squash) February 14, 2023 11:28
@mergify mergify bot added the ready PRs ready to be merged label Feb 14, 2023
@tchaton tchaton merged commit 7e8400d into master Feb 14, 2023
@tchaton tchaton deleted the private_s3 branch February 14, 2023 12:34
tchaton added a commit that referenced this pull request Feb 14, 2023
@tchaton
[App] Add support for private data (#16738)
bbbb89a 
Co-authored-by: thomas <[email protected]>
lexierule pushed a commit that referenced this pull request Feb 15, 2023
@awaelchli @akihironitta
@Borda @pre-commit-ci @dependabot @tchaton @ethanwharris @justusschock
Weekly Patch Release v1.9.2 (#16725)
c5b836a 
* Add .git-blame-ignore-revs (#16709)

Co-authored-by: Jirka Borovec <[email protected]>

* Fix strategy type validation in connectors (#16693)

* Disable strict loading in multiprocessing launcher (#16365)


Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>

* Fix min-epochs and early-stopping triggering too many validation runs (#16719)

Co-authored-by: Jirka Borovec <[email protected]>

* Update hydra-core requirement from <1.3.0,>=1.0.5 to >=1.0.5,<1.4.0 in /requirements (#16736)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [App] Add support for private data (#16738)

Co-authored-by: thomas <[email protected]>

* [App] Add rm one level below project level (#16740)

Co-authored-by: Ethan Harris <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: thomas <[email protected]>

* ci: cleaning caches (#16752)

* CI: Update colossalai version (#16747)

Co-authored-by: Carlos Mocholí <[email protected]>
type

* Update version and changelog for 1.9.2

---------

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: thomas <[email protected]>
Co-authored-by: Ethan Harris <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@hhsecond hhsecond Awaiting requested review from hhsecond

Assignees

@tchaton tchaton

Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tchaton @Borda @ethanwharris @justusschock