Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outputs from on_predict_epoch_end #16655

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 6, 2023

What does this PR do?

Fixes #8479

cc @justusschock @awaelchli @carmocca @Borda

@carmocca carmocca added refactor hooks Related to the hooks API loops Related to the Loop API trainer: predict labels Feb 6, 2023
@carmocca carmocca added this to the 2.0 milestone Feb 6, 2023
@carmocca carmocca self-assigned this Feb 6, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 6, 2023
@carmocca carmocca marked this pull request as ready for review February 6, 2023 18:05
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success
pl-cpu (macOS-11, lightning, 3.9, 1.12) success
pl-cpu (macOS-11, lightning, 3.10, 1.13) success
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
pl-cpu (windows-2022, lightning, 3.9, 1.11) success
pl-cpu (windows-2022, lightning, 3.10, 1.12) success
pl-cpu (windows-2022, lightning, 3.10, 1.13) success
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
pl-cpu (slow, macOS-11, lightning, 3.8, 1.11) success
pl-cpu (slow, ubuntu-20.04, lightning, 3.8, 1.11) success
pl-cpu (slow, windows-2022, lightning, 3.8, 1.11) success
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success

These checks are required after the changes to src/lightning/pytorch/callbacks/callback.py, src/lightning/pytorch/callbacks/prediction_writer.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/loops/dataloader/prediction_loop.py, tests/tests_pytorch/loops/test_prediction_loop.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/trainer/test_trainer.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success

These checks are required after the changes to src/lightning/pytorch/callbacks/callback.py, src/lightning/pytorch/callbacks/prediction_writer.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/loops/dataloader/prediction_loop.py, tests/tests_pytorch/loops/test_prediction_loop.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/trainer/test_trainer.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success

These checks are required after the changes to src/lightning/pytorch/callbacks/callback.py, src/lightning/pytorch/callbacks/prediction_writer.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/loops/dataloader/prediction_loop.py, tests/tests_pytorch/loops/test_prediction_loop.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/trainer/test_trainer.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success

These checks are required after the changes to src/lightning/pytorch/callbacks/callback.py, src/lightning/pytorch/callbacks/prediction_writer.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/loops/dataloader/prediction_loop.py, tests/tests_pytorch/loops/test_prediction_loop.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/trainer/test_trainer.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success

These checks are required after the changes to src/lightning/pytorch/callbacks/callback.py, src/lightning/pytorch/callbacks/prediction_writer.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/loops/dataloader/prediction_loop.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/pytorch/callbacks/callback.py, src/lightning/pytorch/callbacks/prediction_writer.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/loops/dataloader/prediction_loop.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/lightning/pytorch/callbacks/callback.py, src/lightning/pytorch/callbacks/prediction_writer.py, src/lightning/pytorch/core/hooks.py, src/lightning/pytorch/loops/dataloader/prediction_loop.py.

🟢 link-check
Check ID Status
markdown-link-check success

These checks are required after the changes to src/lightning/pytorch/CHANGELOG.md.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot added the ready PRs ready to be merged label Feb 7, 2023
@carmocca carmocca merged commit 35b8543 into master Feb 7, 2023
@carmocca carmocca deleted the refactor/on-predict-epoch-end branch February 7, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hooks Related to the hooks API loops Related to the Loop API pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor trainer: predict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent API for on_predict_epoch_end
3 participants