-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow MLFlowLogger
to work with mlflow-skinny
#16513
Conversation
@carmocca do we currently test in an environment where |
@dconathan We don't install the logger libraries in our CI and instead mock them entirely. This PR could be merged as is as long as the tests pass. Can you also add this change to the CHANGELOG? |
aa6015d
to
94312a0
Compare
MLFlowLogger
to work with mlflow-skinny
What does this PR do?
mlflow-skinny is a variant of the mlflow library that installs the bare-minimum required for tracking: https://pypi.org/project/mlflow-skinny/
Even though this should be enough to enable the MLFlowLogger, it doesn't work because:
https://github.com/Lightning-AI/lightning/blob/4a802e00a843264afd5aea023d8475d4f1b4d360/src/pytorch_lightning/loggers/mlflow.py#L40
checks that precisely the
mlflow
library is installed.This PR looses the restriction to check for the
mlflow-skinny
library too.Fixes #16486
Does your PR introduce any breaking changes? If yes, please list them.
If there are users that have the
mlflow-skinny
library installed and are counting on the MLFlowLogger not working, but I can't see why that would be the case...Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Yup :)
Make sure you had fun coding 🙃