Drop support for PyTorch 1.10 #16492

carmocca · 2023-01-25T00:50:03Z

What does this PR do?

Keeping our version compatibility window, our 2.0 will support (1.11, 1.12, 1.13, 2.0)

Does your PR introduce any breaking changes? If yes, please list them.

Removes PyTorch 1.10 support

cc @carmocca @akihironitta @Borda @justusschock @awaelchli

for more information, see https://pre-commit.ci

github-actions · 2023-01-31T16:47:17Z

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.11, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.8, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, src/lightning/fabric/strategies/launchers/multiprocessing.py, src/lightning/fabric/utilities/imports.py, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, src/lightning/pytorch/callbacks/quantization.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/ddp_spawn.py, src/lightning/pytorch/strategies/hpu_parallel.py, src/lightning/pytorch/strategies/launchers/multiprocessing.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/accelerators/test_ipu.py, tests/tests_pytorch/callbacks/test_finetuning_callback.py, tests/tests_pytorch/callbacks/test_quantization.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/strategies/test_ddp.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, src/lightning/pytorch/callbacks/quantization.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/ddp_spawn.py, src/lightning/pytorch/strategies/hpu_parallel.py, src/lightning/pytorch/strategies/launchers/multiprocessing.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/accelerators/test_ipu.py, tests/tests_pytorch/callbacks/test_finetuning_callback.py, tests/tests_pytorch/callbacks/test_quantization.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/strategies/test_ddp.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, requirements/fabric/base.txt, src/lightning/fabric/strategies/launchers/multiprocessing.py, src/lightning/fabric/utilities/imports.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
pytorch-lightning.Benchmark	success	✅

These checks are required after the changes to requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/strategies/launchers/multiprocessing.py, src/lightning/fabric/utilities/imports.py, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, src/lightning/pytorch/callbacks/quantization.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/ddp_spawn.py, src/lightning/pytorch/strategies/hpu_parallel.py, src/lightning/pytorch/strategies/launchers/multiprocessing.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/accelerators/test_ipu.py, tests/tests_pytorch/callbacks/test_finetuning_callback.py, tests/tests_pytorch/callbacks/test_quantization.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/strategies/test_ddp.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to .azure/ipu-tests.yml, requirements/fabric/base.txt, src/lightning/fabric/strategies/launchers/multiprocessing.py, src/lightning/fabric/utilities/imports.py, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, src/lightning/pytorch/callbacks/quantization.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/ddp_spawn.py, src/lightning/pytorch/strategies/hpu_parallel.py, src/lightning/pytorch/strategies/launchers/multiprocessing.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/accelerators/test_ipu.py, tests/tests_pytorch/callbacks/test_finetuning_callback.py, tests/tests_pytorch/callbacks/test_quantization.py, tests/tests_pytorch/core/test_lightning_module.py, tests/tests_pytorch/strategies/test_ddp.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/lightning/pytorch/callbacks/quantization.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/ddp_spawn.py, src/lightning/pytorch/strategies/hpu_parallel.py, src/lightning/pytorch/strategies/launchers/multiprocessing.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/imports.py, docs/source-pytorch/index.rst, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.11, 11.3.1)	success	✅
build-cuda (3.9, 1.12, 11.6.1)	success	✅
build-cuda (3.9, 1.13, 11.7.1)	success	✅
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.13)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.7.1)	success	✅
build-xla (3.8, 1.12)	success	✅

These checks are required after the changes to dockers/base-ipu/Dockerfile, dockers/base-xla/Dockerfile, dockers/ci-runner-ipu/Dockerfile, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, requirements/fabric/base.txt, environment.yml.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, fabric, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, fabric, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, fabric, 3.9, 1.11)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.12)	success	✅
fabric-cpu (windows-2022, fabric, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/strategies/launchers/multiprocessing.py, src/lightning/fabric/utilities/imports.py, tests/tests_fabric/plugins/collectives/test_torch_collective.py, tests/tests_fabric/test_connector.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/strategies/launchers/multiprocessing.py, src/lightning/fabric/utilities/imports.py, tests/tests_fabric/plugins/collectives/test_torch_collective.py, tests/tests_fabric/test_connector.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt, src/lightning/fabric/strategies/launchers/multiprocessing.py, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/callbacks/quantization.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/ddp_spawn.py, src/lightning/pytorch/strategies/hpu_parallel.py, src/lightning/pytorch/strategies/launchers/multiprocessing.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/imports.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/fabric/strategies/launchers/multiprocessing.py, src/lightning/fabric/utilities/imports.py, src/lightning/pytorch/callbacks/quantization.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/strategies/ddp.py, src/lightning/pytorch/strategies/ddp_spawn.py, src/lightning/pytorch/strategies/hpu_parallel.py, src/lightning/pytorch/strategies/launchers/multiprocessing.py, src/lightning/pytorch/trainer/connectors/accelerator_connector.py, src/lightning/pytorch/utilities/imports.py, requirements/fabric/base.txt, requirements/pytorch/adjust-versions.py, requirements/pytorch/base.txt.

🔴 link-check

Check ID	Status
markdown-link-check	failure	❌

These checks are required after the changes to README.md, src/lightning/fabric/CHANGELOG.md, src/lightning/pytorch/CHANGELOG.md, src/pytorch_lightning/README.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

This reverts commit 9618f73.

Drop support for PyTorch 1.10

37bf62a

carmocca added ci Continuous Integration refactor fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jan 25, 2023

carmocca added this to the 2.0 milestone Jan 25, 2023

carmocca self-assigned this Jan 25, 2023

carmocca and others added 10 commits January 25, 2023 01:51

CHANGELOG

9c5edd6

READMEs

7be4234

mypy

e5cb5cf

Merge branch 'master' into ci/drop-pt-1.20

73c2789

ls

4c0680c

Merge branch 'master' into ci/drop-pt-1.20

315c1e4

New poplar version

f91a1a1

Fixed tests

b6b3794

links

e9924c0

[pre-commit.ci] auto fixes from pre-commit.com hooks

bc4bacc

for more information, see https://pre-commit.ci

carmocca marked this pull request as ready for review January 31, 2023 16:46

carmocca requested review from williamFalcon, lantiga, edenlightning, Borda, awaelchli, justusschock, tchaton and akihironitta as code owners January 31, 2023 16:46

carmocca added 2 commits January 31, 2023 17:52

skip azure badges

1999b81

Table

fc93146

awaelchli approved these changes Jan 31, 2023

View reviewed changes

mergify bot removed the ready PRs ready to be merged label Feb 1, 2023

Merge branch 'master' into ci/drop-pt-1.20

132020c

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 1, 2023

Revert "Push nightly"

c8f8564

This reverts commit 9618f73.

carmocca enabled auto-merge (squash) February 1, 2023 17:03

mergify bot added has conflicts and removed ready PRs ready to be merged labels Feb 1, 2023

Merge branch 'master' into ci/drop-pt-1.20

c1cc0bf

mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Feb 1, 2023

Merge branch 'master' into ci/drop-pt-1.20

8e06b7f

mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 1, 2023

Borda approved these changes Feb 1, 2023

View reviewed changes

carmocca disabled auto-merge February 1, 2023 19:08

lantiga approved these changes Feb 1, 2023

View reviewed changes

lantiga merged commit ef2a608 into master Feb 1, 2023

lantiga deleted the ci/drop-pt-1.20 branch February 1, 2023 19:09

awaelchli mentioned this pull request Feb 6, 2023

Set find_unused_parameters=False as the default #16611

Merged

11 tasks

carmocca mentioned this pull request Feb 6, 2023

Refactor deterministic and benchmark logic #16653

Merged

awaelchli mentioned this pull request Oct 2, 2023

Drop support for PyTorch 1.11 #18691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop support for PyTorch 1.10 #16492

Drop support for PyTorch 1.10 #16492

carmocca commented Jan 25, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 31, 2023 •

edited

Loading

Drop support for PyTorch 1.10 #16492

Drop support for PyTorch 1.10 #16492

Conversation

carmocca commented Jan 25, 2023 • edited by github-actions bot Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

github-actions bot commented Jan 31, 2023 • edited Loading

⛈️ Required checks status: Has failure 🔴

Groups summary

carmocca commented Jan 25, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Jan 31, 2023 •

edited

Loading