Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Trainer(move_metrics_to_cpu=True) #16358

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Remove Trainer(move_metrics_to_cpu=True) #16358

merged 5 commits into from
Jan 16, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 13, 2023 •
edited by github-actions bot
Loading

What does this PR do?

See title

Closes #10595. This issue describes all it's challenges. Mainly that it breaks logging torchmetrics, and that the memory savings of this flag should be negligible (Unless you are logging millions of tensors 😉)

Does your PR introduce any breaking changes? If yes, please list them.

Removes the Trainer flag

cc @Borda @justusschock @awaelchli

@carmocca carmocca added breaking change Includes a breaking change trainer: argument pl Generic label for PyTorch Lightning package labels Jan 13, 2023
@carmocca carmocca self-assigned this Jan 13, 2023
@carmocca carmocca marked this pull request as ready for review January 13, 2023 17:50
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py, src/pytorch_lightning/loops/optimization/manual_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py, tests/tests_pytorch/loops/test_evaluation_loop.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py, src/pytorch_lightning/loops/optimization/manual_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py, tests/tests_pytorch/loops/test_evaluation_loop.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py, src/pytorch_lightning/loops/optimization/manual_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py, tests/tests_pytorch/loops/test_evaluation_loop.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py, src/pytorch_lightning/loops/optimization/manual_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py, tests/tests_pytorch/loops/test_evaluation_loop.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, tests/tests_pytorch/trainer/logging_/test_train_loop_logging.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py, src/pytorch_lightning/loops/optimization/manual_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py, src/pytorch_lightning/loops/optimization/manual_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.7) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.7) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.7) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py, src/pytorch_lightning/loops/optimization/manual_loop.py, src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py, src/pytorch_lightning/trainer/trainer.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@mergify mergify bot removed the has conflicts label Jan 16, 2023
@mergify mergify bot added the ready PRs ready to be merged label Jan 16, 2023
@carmocca carmocca merged commit 36e89df into lite/debug Jan 16, 2023
@carmocca carmocca deleted the lite/debug-move-metrics-cpu branch January 16, 2023 15:32
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Remove Trainer(move_metrics_to_cpu=True) (#16358)
cac825d
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Remove Trainer(move_metrics_to_cpu=True) (#16358)
dcc13d4
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Remove Trainer(move_metrics_to_cpu=True) (#16358)
6272feb
Borda pushed a commit that referenced this pull request Jan 18, 2023
@carmocca @Borda
Remove Trainer(move_metrics_to_cpu=True) (#16358)
7dc3c2f
@carmocca carmocca added this to the 2.0 milestone Jan 19, 2023
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Remove Trainer(move_metrics_to_cpu=True) (#16358)
24c6e0f
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Remove Trainer(move_metrics_to_cpu=True) (#16358)
0ed4944
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Remove Trainer(move_metrics_to_cpu=True) (#16358)
07529e3
lantiga pushed a commit that referenced this pull request Jan 19, 2023
@carmocca @lantiga
Remove Trainer(move_metrics_to_cpu=True) (#16358)
caa82d8
@mzweilin mzweilin mentioned this pull request Jul 27, 2023
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@awaelchli awaelchli awaelchli approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton

Assignees

@carmocca carmocca

Labels
breaking change Includes a breaking change pl Generic label for PyTorch Lightning package ready PRs ready to be merged trainer: argument
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @justusschock