Remove the redundant precision attribute from LightningModule #16203

awaelchli · 2022-12-26T06:19:45Z

What does this PR do?

Today, the LightningModule has a precision attribute that is being set during use with the Trainer. However, it is not reliable to use it in your code, because it only makes sense when a trainer is attached. If no trainer is attached, then the value is simply "outdated" and incorrect. Example: The LightningModule is being used without a Trainer, or within a Lite training loop.

Does your PR introduce any breaking changes? If yes, please list them.

Yes, but there is no point in keeping this unreliable attribute. We also want to change the precision representation to string, see #14857

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda

changelog fix

for more information, see https://pre-commit.ci

github-actions · 2023-01-13T15:41:20Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, tests/tests_pytorch/accelerators/test_ipu.py, tests/tests_pytorch/plugins/precision/hpu/test_hpu.py, tests/tests_pytorch/strategies/test_ddp_fully_sharded_native.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, tests/tests_pytorch/accelerators/test_ipu.py, tests/tests_pytorch/plugins/precision/hpu/test_hpu.py, tests/tests_pytorch/strategies/test_ddp_fully_sharded_native.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, tests/tests_pytorch/accelerators/test_ipu.py, tests/tests_pytorch/plugins/precision/hpu/test_hpu.py, tests/tests_pytorch/strategies/test_ddp_fully_sharded_native.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/utilities/model_summary/model_summary.py, tests/tests_pytorch/accelerators/test_ipu.py, tests/tests_pytorch/plugins/precision/hpu/test_hpu.py, tests/tests_pytorch/strategies/test_ddp_fully_sharded_native.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/utilities/model_summary/model_summary.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/utilities/model_summary/model_summary.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/pytorch_lightning/core/module.py, src/pytorch_lightning/trainer/connectors/data_connector.py, src/pytorch_lightning/utilities/model_summary/model_summary.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Co-authored-by: Carlos Mocholí <[email protected]>

github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 26, 2022

awaelchli mentioned this pull request Jan 3, 2023

Update precision input type annotations #14857

Merged

11 tasks

lantiga deleted the branch lite/debug January 5, 2023 07:07

lantiga closed this Jan 5, 2023

awaelchli reopened this Jan 5, 2023

awaelchli force-pushed the lite/debug-remove-precision-attribute branch from acdd0c2 to 9aba366 Compare January 9, 2023 19:21

awaelchli changed the base branch from lite/debug to master January 9, 2023 19:21

awaelchli and others added 3 commits January 13, 2023 10:55

Remove the precision attribute from LightningModule

e1c1b18

changelog fix

none check

723e3f9

[pre-commit.ci] auto fixes from pre-commit.com hooks

e7618cd

for more information, see https://pre-commit.ci

awaelchli force-pushed the lite/debug-remove-precision-attribute branch from 108fa4b to e7618cd Compare January 13, 2023 09:55

awaelchli changed the base branch from master to lite/debug January 13, 2023 09:55

awaelchli added 3 commits January 13, 2023 11:01

precision to bits

b5daa55

update test

4e55d98

attribute access fixes

2919310

awaelchli marked this pull request as ready for review January 13, 2023 15:40

awaelchli requested review from williamFalcon, tchaton, carmocca and justusschock as code owners January 13, 2023 15:40

move changelog

270311e

carmocca approved these changes Jan 13, 2023

View reviewed changes

justusschock approved these changes Jan 16, 2023

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jan 16, 2023

awaelchli merged commit 1a1ee40 into lite/debug Jan 16, 2023

awaelchli deleted the lite/debug-remove-precision-attribute branch January 16, 2023 10:55

carmocca pushed a commit that referenced this pull request Jan 17, 2023

Remove the redundant precision attribute from LightningModule (#16203)

a8463d5

carmocca pushed a commit that referenced this pull request Jan 17, 2023

Remove the redundant precision attribute from LightningModule (#16203)

f090e98

carmocca pushed a commit that referenced this pull request Jan 17, 2023

Remove the redundant precision attribute from LightningModule (#16203)

ada58a2

Borda pushed a commit that referenced this pull request Jan 18, 2023

Remove the redundant precision attribute from LightningModule (#16203)

04a6f47

carmocca added this to the 2.0 milestone Jan 19, 2023

carmocca pushed a commit that referenced this pull request Jan 19, 2023

Remove the redundant precision attribute from LightningModule (#16203)

a141d04

carmocca added a commit that referenced this pull request Jan 19, 2023

Remove the redundant precision attribute from LightningModule (#16203)

ed96cf3

Co-authored-by: Carlos Mocholí <[email protected]>

carmocca added a commit that referenced this pull request Jan 19, 2023

Remove the redundant precision attribute from LightningModule (#16203)

9a47686

Co-authored-by: Carlos Mocholí <[email protected]>

lantiga pushed a commit that referenced this pull request Jan 19, 2023

Remove the redundant precision attribute from LightningModule (#16203)

83f6d93

Co-authored-by: Carlos Mocholí <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the redundant precision attribute from LightningModule #16203

Remove the redundant precision attribute from LightningModule #16203

awaelchli commented Dec 26, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Jan 13, 2023 •

edited

Loading

Remove the redundant precision attribute from LightningModule #16203

Remove the redundant precision attribute from LightningModule #16203

Conversation

awaelchli commented Dec 26, 2022 • edited by github-actions bot Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

github-actions bot commented Jan 13, 2023 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

awaelchli commented Dec 26, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Jan 13, 2023 •

edited

Loading