Remove deprecated `auto_select_gpus` Trainer argument #16184

awaelchli · 2022-12-22T20:28:10Z

What does this PR do?

Follow up to #16147
Deprecated in 1.9.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda

for more information, see https://pre-commit.ci

github-actions · 2022-12-22T20:33:18Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/trainer/properties/test_auto_gpu_select.py, tests/tests_pytorch/trainer/test_trainer.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/trainer/properties/test_auto_gpu_select.py, tests/tests_pytorch/trainer/test_trainer.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/trainer/properties/test_auto_gpu_select.py, tests/tests_pytorch/trainer/test_trainer.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/trainer/properties/test_auto_gpu_select.py, tests/tests_pytorch/trainer/test_trainer.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/tuner/auto_gpu_select.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: Carlos Mocholí <[email protected]>

remove

e033cb3

github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 22, 2022

awaelchli and others added 2 commits December 22, 2022 21:30

changelog

e9d7dbd

[pre-commit.ci] auto fixes from pre-commit.com hooks

c9611c7

for more information, see https://pre-commit.ci

awaelchli marked this pull request as ready for review December 22, 2022 20:32

awaelchli requested review from williamFalcon, tchaton, carmocca and justusschock as code owners December 22, 2022 20:32

carmocca approved these changes Dec 22, 2022

View reviewed changes

awaelchli added 3 commits December 22, 2022 22:11

fixes

1c2c358

fixes

177895a

unused import

ce2f14b

Borda approved these changes Dec 24, 2022

View reviewed changes

Borda enabled auto-merge (squash) December 24, 2022 03:22

Merge branch 'lite/debug' into lite/debug-remove-auto-select-gpus

1852ab8

mergify bot added the ready PRs ready to be merged label Dec 24, 2022

Borda merged commit 053d4a0 into lite/debug Dec 24, 2022

Borda deleted the lite/debug-remove-auto-select-gpus branch December 24, 2022 04:32

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

304d4a8

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

b05ab52

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

ffee774

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

9853cf2

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

0b1169e

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

2f79e15

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

1e00e54

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

0384af3

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

2db923a

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

257f7f0

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

cef2c63

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

2b009d5

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

cccc8c8

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

6efefef

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

5f7aba9

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

fb085bb

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request Jan 4, 2023

Remove deprecated auto_select_gpus Trainer argument (#16184)

f35f449

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca added a commit that referenced this pull request Jan 11, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

c8a7d48

carmocca added a commit that referenced this pull request Jan 17, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

1a45097

carmocca added a commit that referenced this pull request Jan 17, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

ea7d01c

carmocca added a commit that referenced this pull request Jan 17, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

bc7b420

Borda pushed a commit that referenced this pull request Jan 18, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

628eeb5

carmocca added this to the 2.0 milestone Jan 19, 2023

carmocca added a commit that referenced this pull request Jan 19, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

878ce66

carmocca added a commit that referenced this pull request Jan 19, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

7681055

Co-authored-by: Carlos Mocholí <[email protected]>

carmocca added a commit that referenced this pull request Jan 19, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

7642ae5

Co-authored-by: Carlos Mocholí <[email protected]>

lantiga pushed a commit that referenced this pull request Jan 19, 2023

Remove the deprecated auto_select_gpus Trainer argument (#16184)

9f0116f

Co-authored-by: Carlos Mocholí <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated `auto_select_gpus` Trainer argument #16184

Remove deprecated `auto_select_gpus` Trainer argument #16184

awaelchli commented Dec 22, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 22, 2022 •

edited

Loading

Remove deprecated auto_select_gpus Trainer argument #16184

Remove deprecated auto_select_gpus Trainer argument #16184

Conversation

awaelchli commented Dec 22, 2022 • edited by github-actions bot Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

github-actions bot commented Dec 22, 2022 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

Remove deprecated `auto_select_gpus` Trainer argument #16184

Remove deprecated `auto_select_gpus` Trainer argument #16184

awaelchli commented Dec 22, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 22, 2022 •

edited

Loading