Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add amp_scaling_state (apex) migration #16161

Merged
merged 6 commits into from
Dec 22, 2022
Merged

Add amp_scaling_state (apex) migration #16161

merged 6 commits into from
Dec 22, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 21, 2022 •
edited by github-actions bot
Loading

What does this PR do?

See title

Fixes #16149 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @Borda @justusschock @awaelchli @carmocca

@carmocca carmocca added this to the v1.9 milestone Dec 21, 2022
@carmocca carmocca self-assigned this Dec 21, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success ✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success ✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success ✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success ✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success ✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success ✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success ✅
pl-cpu (macOS-11, lightning, 3.8, 1.13) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success ✅
pl-cpu (windows-2022, lightning, 3.8, 1.13) success ✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, tests/tests_pytorch/utilities/migration/test_migration.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, tests/tests_pytorch/utilities/migration/test_migration.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, tests/tests_pytorch/utilities/migration/test_migration.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success ✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py, tests/tests_pytorch/utilities/migration/test_migration.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py.

🟢 mypy
Check ID Status
mypy success ✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success ✅
install-pkg (ubuntu-22.04, app, 3.10) success ✅
install-pkg (ubuntu-22.04, fabric, 3.7) success ✅
install-pkg (ubuntu-22.04, fabric, 3.10) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.7) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.10) success ✅
install-pkg (ubuntu-22.04, lightning, 3.7) success ✅
install-pkg (ubuntu-22.04, lightning, 3.10) success ✅
install-pkg (ubuntu-22.04, notset, 3.7) success ✅
install-pkg (ubuntu-22.04, notset, 3.10) success ✅
install-pkg (macOS-12, app, 3.7) success ✅
install-pkg (macOS-12, app, 3.10) success ✅
install-pkg (macOS-12, fabric, 3.7) success ✅
install-pkg (macOS-12, fabric, 3.10) success ✅
install-pkg (macOS-12, pytorch, 3.7) success ✅
install-pkg (macOS-12, pytorch, 3.10) success ✅
install-pkg (macOS-12, lightning, 3.7) success ✅
install-pkg (macOS-12, lightning, 3.10) success ✅
install-pkg (macOS-12, notset, 3.7) success ✅
install-pkg (macOS-12, notset, 3.10) success ✅
install-pkg (windows-2022, app, 3.7) success ✅
install-pkg (windows-2022, app, 3.10) success ✅
install-pkg (windows-2022, fabric, 3.7) success ✅
install-pkg (windows-2022, fabric, 3.10) success ✅
install-pkg (windows-2022, pytorch, 3.7) success ✅
install-pkg (windows-2022, pytorch, 3.10) success ✅
install-pkg (windows-2022, lightning, 3.7) success ✅
install-pkg (windows-2022, lightning, 3.10) success ✅
install-pkg (windows-2022, notset, 3.7) success ✅
install-pkg (windows-2022, notset, 3.10) success ✅

These checks are required after the changes to src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/utilities/migration/migration.py, src/pytorch_lightning/utilities/migration/utils.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@carmocca carmocca enabled auto-merge (squash) December 21, 2022 12:37
@carmocca carmocca disabled auto-merge December 22, 2022 01:56
@Borda Borda merged commit 4f02198 into lite/debug Dec 22, 2022
@Borda Borda deleted the apex/migration branch December 22, 2022 13:02
@mergify mergify bot added the ready PRs ready to be merged label Dec 22, 2022
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
f65518b 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
d4e1451 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
5770149 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
5365b45 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
fe4f21f 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
cdaacd4 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
2ec2469 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
ce50996 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
7d948f7 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
865bdf9 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
fd3c271 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
429b49a 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
3e468a8 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 4, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
c70eaa8 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 11, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
ae86473 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
308b62a 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
edf90d1 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 17, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
6003312 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
Borda pushed a commit that referenced this pull request Jan 18, 2023
@carmocca @Borda
Add amp_scaling_state (apex) migration (#16161)
fa8613a 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
@carmocca carmocca modified the milestones: v1.9, 2.0 Jan 19, 2023
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
217158d 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
4509132 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
carmocca added a commit that referenced this pull request Jan 19, 2023
@carmocca
Add amp_scaling_state (apex) migration (#16161)
62eebf6 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
lantiga pushed a commit that referenced this pull request Jan 19, 2023
@carmocca @lantiga
Add amp_scaling_state (apex) migration (#16161)
b7fe285 
Co-authored-by: Adrian Wälchli <[email protected]>
Fixes #16149 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
pl Generic label for PyTorch Lightning package precision: apex (removed) NVIDIA/apex precision ready PRs ready to be merged refactor
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carmocca @awaelchli @Borda