Remove nivida/apex #16149

carmocca · 2022-12-21T02:26:46Z

What does this PR do?

See title

Does your PR introduce any breaking changes? If yes, please list them.

Removes apex support

cc @justusschock @awaelchli @Borda @carmocca

github-actions · 2022-12-21T02:27:29Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, pytorch, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, pytorch, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (windows-2022, pytorch, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, pytorch, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest)	success	✅
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11)	success	✅
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.13)	success	✅

These checks are required after the changes to src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure IPU

Check ID	Status
pytorch-lightning (IPUs)	success	✅

These checks are required after the changes to src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/helpers/runif.py, tests/tests_pytorch/models/test_amp.py, tests/tests_pytorch/models/test_hooks.py, tests/tests_pytorch/models/test_horovod.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/test_amp_plugins.py, tests/tests_pytorch/strategies/test_deepspeed_strategy.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/trainer/optimization/test_manual_optimization.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.10, 11.3.1)	success	✅
build-cuda (3.9, 1.11, 11.3.1)	success	✅
build-cuda (3.9, 1.12, 11.6.1)	success	✅
build-cuda (3.9, 1.13, 11.6.1)	success	✅
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.10)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.10, 11.3.1)	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.6.1)	success	✅
build-xla (3.7, 1.12)	success	✅

These checks are required after the changes to dockers/base-cuda/Dockerfile, environment.yml.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.7)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.7)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.7)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.7)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.7)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.7)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.7)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.7)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.7)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.7)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.7)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.7)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.7)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.7)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.7)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/pytorch_lightning/loops/optimization/optimizer_loop.py, src/pytorch_lightning/plugins/__init__.py, src/pytorch_lightning/plugins/precision/__init__.py, src/pytorch_lightning/plugins/precision/apex_amp.py, src/pytorch_lightning/plugins/precision/deepspeed.py, src/pytorch_lightning/plugins/precision/native_amp.py, src/pytorch_lightning/strategies/deepspeed.py, src/pytorch_lightning/trainer/connectors/accelerator_connector.py, src/pytorch_lightning/trainer/connectors/checkpoint_connector.py, src/pytorch_lightning/trainer/trainer.py, src/pytorch_lightning/utilities/__init__.py, src/pytorch_lightning/utilities/enums.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

src/pytorch_lightning/CHANGELOG.md

awaelchli · 2022-12-21T02:54:15Z

src/pytorch_lightning/trainer/connectors/checkpoint_connector.py

+        if "amp_scaling_state" in self._loaded_checkpoint:
+            rank_zero_warn("This checkpoint contains apex AMP data, but apex support has been removed.")


Should we remove this as well?

Fine with me either way. I thought having a warning could be useful

Alternatively we could also have a migration that removes the key and warns that this state gets dropped. This would keep the main code base clean and move the "legacy" code to the migration utilities.

Leaving this for a follow-up

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added 2 commits December 21, 2022 03:24

Remove nivida/apex

2034508

Remove nivida/apex

21f8118

carmocca added refactor breaking change Includes a breaking change precision: apex (removed) NVIDIA/apex precision labels Dec 21, 2022

carmocca added this to the v1.9 milestone Dec 21, 2022

carmocca self-assigned this Dec 21, 2022

carmocca requested review from williamFalcon, tchaton, awaelchli, justusschock, Borda and akihironitta as code owners December 21, 2022 02:26

github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 21, 2022

carmocca commented Dec 21, 2022

View reviewed changes

src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved

Update src/pytorch_lightning/CHANGELOG.md

5607d33

carmocca mentioned this pull request Dec 21, 2022

Remove horovod #16150

Merged

awaelchli approved these changes Dec 21, 2022

View reviewed changes

akihironitta approved these changes Dec 21, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Dec 21, 2022

carmocca merged commit e544676 into lite/debug Dec 21, 2022

carmocca deleted the remove/apex branch December 21, 2022 11:15

carmocca mentioned this pull request Dec 21, 2022

Add amp_scaling_state (apex) migration #16161

Merged

Borda pushed a commit that referenced this pull request Dec 22, 2022

Add amp_scaling_state (apex) migration (#16161)

4f02198

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 4, 2023

Remove nivida/apex (#16149)

ec77817

carmocca added a commit that referenced this pull request Jan 4, 2023

Add amp_scaling_state (apex) migration (#16161)

f65518b

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 4, 2023

Remove nivida/apex (#16149)

912a227

carmocca added a commit that referenced this pull request Jan 4, 2023

Add amp_scaling_state (apex) migration (#16161)

d4e1451

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 4, 2023

Remove nivida/apex (#16149)

ecc530f

carmocca added a commit that referenced this pull request Jan 4, 2023

Add amp_scaling_state (apex) migration (#16161)

7d948f7

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 4, 2023

Remove nivida/apex (#16149)

0147859

carmocca added a commit that referenced this pull request Jan 4, 2023

Add amp_scaling_state (apex) migration (#16161)

865bdf9

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 4, 2023

Add amp_scaling_state (apex) migration (#16161)

fd3c271

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 4, 2023

Remove nivida/apex (#16149)

34a3d21

carmocca added a commit that referenced this pull request Jan 4, 2023

Add amp_scaling_state (apex) migration (#16161)

429b49a

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 4, 2023

Remove nivida/apex (#16149)

3c026c1

carmocca added a commit that referenced this pull request Jan 4, 2023

Add amp_scaling_state (apex) migration (#16161)

3e468a8

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 4, 2023

Remove nivida/apex (#16149)

25ae881

carmocca added a commit that referenced this pull request Jan 4, 2023

Add amp_scaling_state (apex) migration (#16161)

c70eaa8

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 11, 2023

Remove nivida/apex (#16149)

bde6b4f

carmocca added a commit that referenced this pull request Jan 11, 2023

Add amp_scaling_state (apex) migration (#16161)

ae86473

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 17, 2023

Remove nivida/apex (#16149)

15d3ba2

carmocca added a commit that referenced this pull request Jan 17, 2023

Add amp_scaling_state (apex) migration (#16161)

308b62a

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 17, 2023

Remove nivida/apex (#16149)

719b125

carmocca added a commit that referenced this pull request Jan 17, 2023

Add amp_scaling_state (apex) migration (#16161)

edf90d1

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 17, 2023

Remove nivida/apex (#16149)

ad1a777

carmocca added a commit that referenced this pull request Jan 17, 2023

Add amp_scaling_state (apex) migration (#16161)

6003312

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

Borda pushed a commit that referenced this pull request Jan 18, 2023

Remove nivida/apex (#16149)

d4d275f

Borda pushed a commit that referenced this pull request Jan 18, 2023

Add amp_scaling_state (apex) migration (#16161)

fa8613a

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca modified the milestones: v1.9, 2.0 Jan 19, 2023

carmocca added a commit that referenced this pull request Jan 19, 2023

Remove nivida/apex (#16149)

675676b

carmocca added a commit that referenced this pull request Jan 19, 2023

Add amp_scaling_state (apex) migration (#16161)

217158d

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 19, 2023

Remove nivida/apex (#16149)

f26030e

carmocca added a commit that referenced this pull request Jan 19, 2023

Add amp_scaling_state (apex) migration (#16161)

4509132

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

carmocca added a commit that referenced this pull request Jan 19, 2023

Remove nivida/apex (#16149)

f66caa6

carmocca added a commit that referenced this pull request Jan 19, 2023

Add amp_scaling_state (apex) migration (#16161)

62eebf6

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

lantiga pushed a commit that referenced this pull request Jan 19, 2023

Remove nivida/apex (#16149)

f17cacb

lantiga pushed a commit that referenced this pull request Jan 19, 2023

Add amp_scaling_state (apex) migration (#16161)

b7fe285

Co-authored-by: Adrian Wälchli <[email protected]> Fixes #16149 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove nivida/apex #16149

Remove nivida/apex #16149

carmocca commented Dec 21, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 21, 2022 •

edited

Loading

awaelchli Dec 21, 2022

carmocca Dec 21, 2022

awaelchli Dec 21, 2022 •

edited

Loading

carmocca Dec 21, 2022

		if "amp_scaling_state" in self._loaded_checkpoint:
		rank_zero_warn("This checkpoint contains apex AMP data, but apex support has been removed.")

Remove nivida/apex #16149

Remove nivida/apex #16149

Conversation

carmocca commented Dec 21, 2022 • edited by github-actions bot Loading

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

github-actions bot commented Dec 21, 2022 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

awaelchli Dec 21, 2022

Choose a reason for hiding this comment

carmocca Dec 21, 2022

Choose a reason for hiding this comment

awaelchli Dec 21, 2022 • edited Loading

Choose a reason for hiding this comment

carmocca Dec 21, 2022

Choose a reason for hiding this comment

carmocca commented Dec 21, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 21, 2022 •

edited

Loading

awaelchli Dec 21, 2022 •

edited

Loading