Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lite: Remove legacy code #15953

Merged
merged 9 commits into from
Dec 9, 2022
Merged

Lite: Remove legacy code #15953

merged 9 commits into from
Dec 9, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 8, 2022

What does this PR do?

Removes the pytorch_lightning.lite source code in favor of the lightning_fabric package.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) success
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success
pl-cpu (macOS-11, lightning, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success
pl-cpu (windows-2022, lightning, 3.8, 1.13) success

These checks are required after the changes to src/lightning_fabric/wrappers.py, src/pytorch_lightning/lite/__init__.py, src/pytorch_lightning/lite/lite.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/lite/__init__.py, tests/tests_pytorch/lite/test_lite.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success

These checks are required after the changes to src/pytorch_lightning/lite/__init__.py, src/pytorch_lightning/lite/lite.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/lite/__init__.py, tests/tests_pytorch/lite/test_lite.py, src/lightning_fabric/wrappers.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success

These checks are required after the changes to src/lightning_fabric/wrappers.py, src/pytorch_lightning/lite/__init__.py, src/pytorch_lightning/lite/lite.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/lite/__init__.py, tests/tests_pytorch/lite/test_lite.py.

🟢 pytorch_lightning: Azure IPU
Check ID Status
pytorch-lightning (IPUs) success

These checks are required after the changes to src/lightning_fabric/wrappers.py, src/pytorch_lightning/lite/__init__.py, src/pytorch_lightning/lite/lite.py, tests/tests_pytorch/deprecated_api/test_remove_1-10.py, tests/tests_pytorch/lite/__init__.py, tests/tests_pytorch/lite/test_lite.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success

These checks are required after the changes to src/pytorch_lightning/lite/__init__.py, src/pytorch_lightning/lite/lite.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, fabric, 3.8, 1.11) success
fabric-cpu (macOS-11, fabric, 3.9, 1.12) success
fabric-cpu (macOS-11, fabric, 3.10, 1.13) success
fabric-cpu (macOS-11, fabric, 3.7, 1.10, oldest) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.10) success
fabric-cpu (ubuntu-20.04, fabric, 3.9, 1.11) success
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.12) success
fabric-cpu (ubuntu-20.04, fabric, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.7, 1.10, oldest) success
fabric-cpu (windows-2022, fabric, 3.9, 1.11) success
fabric-cpu (windows-2022, fabric, 3.10, 1.12) success
fabric-cpu (windows-2022, fabric, 3.10, 1.13) success
fabric-cpu (windows-2022, fabric, 3.7, 1.10, oldest) success
fabric-cpu (macOS-11, lightning, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success
fabric-cpu (windows-2022, lightning, 3.8, 1.13) success

These checks are required after the changes to src/lightning_fabric/wrappers.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success

These checks are required after the changes to src/lightning_fabric/wrappers.py.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, app, 3.8, latest) success
app-pytest (macOS-11, app, 3.8, oldest) success
app-pytest (macOS-11, lightning, 3.9, latest) success
app-pytest (ubuntu-20.04, app, 3.8, latest) success
app-pytest (ubuntu-20.04, app, 3.8, oldest) success
app-pytest (ubuntu-20.04, lightning, 3.9, latest) success
app-pytest (windows-2022, app, 3.8, latest) success
app-pytest (windows-2022, app, 3.8, oldest) success
app-pytest (windows-2022, lightning, 3.8, latest) success

These checks are required after the changes to tests/tests_app/core/scripts/lightning_overrides.py, tests/tests_app/utilities/test_introspection.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning_fabric/wrappers.py, src/pytorch_lightning/lite/__init__.py, src/pytorch_lightning/lite/lite.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.7) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.7) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.7) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.7) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (macOS-12, app, 3.7) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.7) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.7) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.7) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (windows-2022, app, 3.7) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.7) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.7) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.7) success
install-pkg (windows-2022, lightning, 3.10) success

These checks are required after the changes to src/lightning_fabric/wrappers.py, src/pytorch_lightning/lite/__init__.py, src/pytorch_lightning/lite/lite.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Dec 9, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Dec 9, 2022
@awaelchli awaelchli enabled auto-merge (squash) December 9, 2022 14:29
@awaelchli awaelchli merged commit 7282d5c into lite/debug Dec 9, 2022
@awaelchli awaelchli deleted the lite/debug-legacy-code branch December 9, 2022 17:17
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca pushed a commit that referenced this pull request Jan 4, 2023
carmocca added a commit that referenced this pull request Jan 11, 2023
carmocca added a commit that referenced this pull request Jan 11, 2023
carmocca added a commit that referenced this pull request Jan 17, 2023
carmocca added a commit that referenced this pull request Jan 17, 2023
carmocca added a commit that referenced this pull request Jan 17, 2023
Borda pushed a commit that referenced this pull request Jan 18, 2023
@carmocca carmocca added this to the 2.0 milestone Jan 19, 2023
carmocca added a commit that referenced this pull request Jan 19, 2023
carmocca added a commit that referenced this pull request Jan 19, 2023
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca added a commit that referenced this pull request Jan 19, 2023
Co-authored-by: Carlos Mocholí <[email protected]>
lantiga pushed a commit that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants