-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neptune.init deprecation fix #15393
neptune.init deprecation fix #15393
Conversation
neptune.init is deprecated. Support will end in neptune-client==1.0.0. neptune.init_run should be used instead.
@wouterzwerink This is a great start, thanks for providing the fix for this. Two more things we need to do:
We can of course help with these items. |
neptune.new.init is deprecated, neptune.new.init_run should be used instead. This commit updates the test files to of the NeptuneLogger to use init_run.
@awaelchli I have updated the references to |
@wouterzwerink That's really good news. Thanks for checking! |
What does this PR do?
neptune.init is deprecated. Support will end in neptune-client==1.0.0. neptune.init_run should be used instead.
Fixes #15394
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃