Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues when RichProgressBar disabled #15376

Merged
merged 10 commits into from
Oct 29, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 28, 2022

What does this PR do?

Fixes issues found in #15321. When disabling the progress bar and using it in the Trainer, we get assertion errors and NoneType attribute errors. The added test reproduces several issues.

Q: When do we have a disabled progress bar in the trainer?
A: When running with DDP, we internally call progress_bar.disable() on rank > 0 to avoid showing a bar for each process.

This PR fixes RichProgressBar in combination with DDP and other multi-process strategies.

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @kaushikb11 @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 28, 2022
@awaelchli awaelchli added bug Something isn't working progress bar: rich labels Oct 28, 2022
@awaelchli awaelchli self-assigned this Oct 28, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Oct 28, 2022
@awaelchli awaelchli marked this pull request as ready for review October 28, 2022 00:06
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Oct 28, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 28, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 28, 2022 10:34
@awaelchli awaelchli merged commit 6b0d41c into master Oct 29, 2022
@awaelchli awaelchli deleted the bugfix/rich-disabled branch October 29, 2022 00:52
@awaelchli awaelchli modified the milestones: v1.8.x, v1.8 Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package progress bar: rich ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants