-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues when RichProgressBar disabled #15376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
awaelchli
requested review from
carmocca,
rohitgr7,
otaj,
justusschock and
Borda
as code owners
October 28, 2022 00:06
rohitgr7
approved these changes
Oct 28, 2022
carmocca
approved these changes
Oct 28, 2022
mergify
bot
added
ready
PRs ready to be merged
has conflicts
and removed
ready
PRs ready to be merged
labels
Oct 28, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
pl
Generic label for PyTorch Lightning package
progress bar: rich
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issues found in #15321. When disabling the progress bar and using it in the Trainer, we get assertion errors and NoneType attribute errors. The added test reproduces several issues.
Q: When do we have a disabled progress bar in the trainer?
A: When running with DDP, we internally call
progress_bar.disable()
on rank > 0 to avoid showing a bar for each process.This PR fixes RichProgressBar in combination with DDP and other multi-process strategies.
Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @kaushikb11 @rohitgr7