Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Add env variables to desactivate pull and push of the App State #15367

Merged
merged 29 commits into from
Oct 28, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 27, 2022

What does this PR do?

This PR introduces 2 env variables to disable state manipulation through the Rest API:

ENABLE_PULLING_STATE_ENDPOINT=0 # Used to disable getting the latest state
ENABLE_PUSHING_STATE_ENDPOINT=0  # Used to disable pushing deltas through the Rest API

Furthermore, this PR adds a layout endpoint to remove the need for the UI to fetch the AppState.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton tchaton self-assigned this Oct 27, 2022
@tchaton tchaton added the app (removed) Generic label for Lightning App package label Oct 27, 2022
@tchaton tchaton marked this pull request as draft October 27, 2022 14:44
@tchaton tchaton marked this pull request as ready for review October 27, 2022 15:39
@tchaton tchaton requested a review from alecmerdler October 27, 2022 15:40
@tchaton tchaton added this to the v1.8 milestone Oct 27, 2022
@mergify mergify bot removed the has conflicts label Oct 27, 2022
@tchaton tchaton requested a review from manskx October 28, 2022 08:10
@tchaton tchaton enabled auto-merge (squash) October 28, 2022 08:39
@mergify mergify bot added the ready PRs ready to be merged label Oct 28, 2022
src/lightning_app/core/constants.py Show resolved Hide resolved
tests/tests_app/conftest.py Outdated Show resolved Hide resolved
@tchaton tchaton merged commit b6ebc7b into master Oct 28, 2022
@tchaton tchaton deleted the add_an_env_to_disable_state_endpoints branch October 28, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants