-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App] Add env variables to desactivate pull and push of the App State #15367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
hhsecond,
lantiga,
awaelchli and
manskx
as code owners
October 27, 2022 14:44
alecmerdler
reviewed
Oct 27, 2022
alecmerdler
reviewed
Oct 27, 2022
alecmerdler
reviewed
Oct 27, 2022
alecmerdler
reviewed
Oct 27, 2022
manskx
reviewed
Oct 27, 2022
manskx
reviewed
Oct 27, 2022
manskx
reviewed
Oct 27, 2022
…b.com/Lightning-AI/lightning into add_an_env_to_disable_state_endpoints
lantiga
approved these changes
Oct 28, 2022
manskx
approved these changes
Oct 28, 2022
…b.com/Lightning-AI/lightning into add_an_env_to_disable_state_endpoints
…b.com/Lightning-AI/lightning into add_an_env_to_disable_state_endpoints
tchaton
requested review from
Borda,
carmocca,
akihironitta and
otaj
as code owners
October 28, 2022 10:00
awaelchli
approved these changes
Oct 28, 2022
…b.com/Lightning-AI/lightning into add_an_env_to_disable_state_endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces 2 env variables to disable state manipulation through the Rest API:
Furthermore, this PR adds a layout endpoint to remove the need for the UI to fetch the AppState.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda