Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pickling issues with rich progress bar #15319

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 25, 2022

What does this PR do?

Fixes #15212

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @kaushikb11 @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 25, 2022
@awaelchli awaelchli marked this pull request as ready for review October 25, 2022 23:29
@awaelchli awaelchli added bug Something isn't working progress bar: rich labels Oct 25, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Oct 25, 2022
@awaelchli awaelchli self-assigned this Oct 25, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 26, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 26, 2022 12:54
@awaelchli awaelchli merged commit ac89d70 into master Oct 26, 2022
@awaelchli awaelchli deleted the bugfix/rich-picklable branch October 26, 2022 15:25
@carmocca carmocca modified the milestones: v1.8.x, v1.8 Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package progress bar: rich ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unable to pickle (dump) LightningModule object if RichProgressBar callback is added to Trainer
4 participants