Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Remove --instance-types from cluster creation #15314

Merged
merged 10 commits into from
Oct 31, 2022

Conversation

luca3rd
Copy link
Contributor

@luca3rd luca3rd commented Oct 25, 2022

What does this PR do?

Removes the ability to specify --instance-types when creating clusters.

Instead, all clusters will be able to use every instance type supported by the platform.

NOTE

Users can still set custom instance types with the --edit-before-creation option. Since this is considered an "advanced" option (you're modifying the JSON just before it's sent to the platform), we will allow this behaviour.

Does your PR introduce any breaking changes? If yes, please list them.

Yes:

  • lightning create cluster ... --instance-types will no longer work.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 25, 2022
@luca3rd luca3rd force-pushed the ENG-1454-remove-instance-types-from-the-cli branch from 9a46ef0 to e3151ad Compare October 25, 2022 18:08
@luca3rd luca3rd changed the title Remove instance types from cluster creation Remove --instance-types from cluster creation Oct 26, 2022
@luca3rd luca3rd force-pushed the ENG-1454-remove-instance-types-from-the-cli branch from 179657e to e8c15d7 Compare October 26, 2022 00:10
@luca3rd luca3rd marked this pull request as ready for review October 26, 2022 00:10
@luca3rd luca3rd changed the title Remove --instance-types from cluster creation [App] Remove --instance-types from cluster creation Oct 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 26, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 27, 2022
@luca3rd luca3rd added this to the v1.8 milestone Oct 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 27, 2022
@luca3rd luca3rd enabled auto-merge (squash) October 27, 2022 13:48
@mergify mergify bot added the ready PRs ready to be merged label Oct 27, 2022
@luca3rd luca3rd self-assigned this Oct 27, 2022
@luca3rd luca3rd merged commit ec156ad into master Oct 31, 2022
@luca3rd luca3rd deleted the ENG-1454-remove-instance-types-from-the-cli branch October 31, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants