-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App] Remove --instance-types from cluster creation #15314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Oct 25, 2022
luca3rd
force-pushed
the
ENG-1454-remove-instance-types-from-the-cli
branch
from
October 25, 2022 18:08
9a46ef0
to
e3151ad
Compare
luca3rd
changed the title
Remove instance types from cluster creation
Remove --instance-types from cluster creation
Oct 26, 2022
luca3rd
force-pushed
the
ENG-1454-remove-instance-types-from-the-cli
branch
from
October 26, 2022 00:10
179657e
to
e8c15d7
Compare
luca3rd
requested review from
tchaton,
awaelchli,
manskx,
hhsecond and
lantiga
as code owners
October 26, 2022 00:10
awaelchli
approved these changes
Oct 26, 2022
luca3rd
changed the title
Remove --instance-types from cluster creation
[App] Remove --instance-types from cluster creation
Oct 26, 2022
nicolai86
approved these changes
Oct 26, 2022
ethanwharris
approved these changes
Oct 26, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Oct 27, 2022
manskx
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the ability to specify
--instance-types
when creating clusters.Instead, all clusters will be able to use every instance type supported by the platform.
NOTE
Users can still set custom instance types with the
--edit-before-creation
option. Since this is considered an "advanced" option (you're modifying the JSON just before it's sent to the platform), we will allow this behaviour.Does your PR introduce any breaking changes? If yes, please list them.
Yes:
lightning create cluster ... --instance-types
will no longer work.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda