Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the detection of interactive mode #15293

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 25, 2022

What does this PR do?

Fixes #13373

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 25, 2022
@awaelchli awaelchli added fabric lightning.fabric.Fabric feature Is an improvement or enhancement labels Oct 25, 2022
@awaelchli awaelchli added this to the v1.9 milestone Oct 25, 2022
@awaelchli awaelchli marked this pull request as ready for review October 25, 2022 03:04
@awaelchli awaelchli self-assigned this Oct 25, 2022
@awaelchli awaelchli added the community This PR is from the community label Oct 25, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2022
@Borda Borda enabled auto-merge (squash) October 25, 2022 11:01
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Oct 26, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Oct 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 26, 2022
@Borda Borda merged commit 38a9e69 into master Oct 26, 2022
@Borda Borda deleted the bugfix/extend-interactive-mode branch October 26, 2022 15:24
@carmocca carmocca modified the milestones: v1.9, v1.8 Oct 26, 2022
@awaelchli awaelchli added fun Staff contributions outside working hours - to differentiate from the "community" label and removed community This PR is from the community labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric feature Is an improvement or enhancement fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Trainer.test() hangs when run from python interactive shell with multiple GPUs
6 participants