Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 25, 2022

What does this PR do?

Fixes #15218

I tried adding a test but when running in pytest, the issue somehow does not reproduce. Only when you run the code in #15218 as a script will it trigger the __del__ on the queue.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli

@awaelchli awaelchli added bug Something isn't working fabric lightning.fabric.Fabric labels Oct 25, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Oct 25, 2022
@awaelchli awaelchli self-assigned this Oct 25, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 25, 2022
@awaelchli awaelchli marked this pull request as ready for review October 25, 2022 01:20
@awaelchli awaelchli changed the title Fix a peculiar issue with multiprocessing so strange it is hard to find a good PR title Fix a peculiar issue with multiprocessing so strange it is hard to find PR title Oct 25, 2022
@awaelchli awaelchli changed the title Fix a peculiar issue with multiprocessing so strange it is hard to find PR title Fix a peculiar issue with multiprocessing so strange it is impossible to find PR title Oct 25, 2022
@awaelchli awaelchli changed the title Fix a peculiar issue with multiprocessing so strange it is impossible to find PR title Fix a peculiar issue with multiprocessing so strange it is impossible to find a PR title Oct 25, 2022
@awaelchli awaelchli added the community This PR is from the community label Oct 25, 2022
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the title of the PR!

Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for this?

@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2022
@awaelchli awaelchli changed the title Fix a peculiar issue with multiprocessing so strange it is impossible to find a PR title Fix exception when creating a multiprocessing Pool after importing Lightning Oct 25, 2022
@awaelchli awaelchli enabled auto-merge (squash) October 25, 2022 21:15
@awaelchli awaelchli merged commit 6426d43 into master Oct 27, 2022
@awaelchli awaelchli deleted the bugfix/pool-atexit branch October 27, 2022 10:16
@carmocca carmocca modified the milestones: v1.8.x, v1.8 Oct 27, 2022
@awaelchli awaelchli added fun Staff contributions outside working hours - to differentiate from the "community" label and removed community This PR is from the community labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fabric lightning.fabric.Fabric fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Creating a multiprocessing pool while PyTorch Lightning is imported leads to an exception

6 participants