Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSH key management to CLI #15291

Merged
merged 17 commits into from
Oct 28, 2022
Merged

Add SSH key management to CLI #15291

merged 17 commits into from
Oct 28, 2022

Conversation

nicolai86
Copy link
Contributor

@nicolai86 nicolai86 commented Oct 24, 2022

What does this PR do?

This PR adds three new CLI commands enabling users to manage their SSH keys for lightning cloud and BYOC.
There will be a separate follow-up PR to document this functionality properly.
As SSH support is disabled via a feature flag these can be split up.

This was discussed with @awaelchli who in turn also touched base with Will:

lightning add ssh-key --public-key /path/to/key.pub
lightning add ssh-key --public-key "ssh-rsa ..." # in case you use a hardware key
lightning list ssh-keys
lightning remove ssh-key <key-id>

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 24, 2022
@Borda Borda added this to the v1.9 milestone Oct 25, 2022
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Oct 25, 2022
@nicolai86 nicolai86 force-pushed the nicolai86/ENG-1408-ssh-key-mgmt branch from e87f6a2 to 6b7d9ac Compare October 25, 2022 16:39
@mergify mergify bot removed the has conflicts label Oct 25, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 25, 2022
as discussed with Adrian, we want to adopt "lightning add" and "lightning remove" for  ssh-keys,
as the resource already exists.
@nicolai86 nicolai86 force-pushed the nicolai86/ENG-1408-ssh-key-mgmt branch from 6b7d9ac to 8b5a264 Compare October 25, 2022 19:01
@nicolai86 nicolai86 requested a review from awaelchli October 25, 2022 20:13
@nicolai86 nicolai86 force-pushed the nicolai86/ENG-1408-ssh-key-mgmt branch from 544726a to 087175f Compare October 25, 2022 20:38
src/lightning_app/cli/lightning_cli_remove.py Show resolved Hide resolved
src/lightning_app/cli/lightning_cli_remove.py Outdated Show resolved Hide resolved
src/lightning_app/cli/cmd_ssh_keys.py Outdated Show resolved Hide resolved
src/lightning_app/cli/lightning_cli_add.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Oct 27, 2022
Copy link
Contributor

@manskx manskx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@mergify mergify bot added the ready PRs ready to be merged label Oct 28, 2022
@nicolai86 nicolai86 modified the milestones: v1.9, v1.8.x, v1.8 Oct 28, 2022
@Borda Borda merged commit adc8238 into master Oct 28, 2022
@Borda Borda deleted the nicolai86/ENG-1408-ssh-key-mgmt branch October 28, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants