-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSH key management to CLI #15291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolai86
requested review from
tchaton,
awaelchli,
manskx,
hhsecond,
lantiga,
williamFalcon,
Borda,
kaushikb11 and
rohitgr7
as code owners
October 24, 2022 23:51
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Oct 24, 2022
nicolai86
requested review from
carmocca,
justusschock,
otaj,
edenlightning and
akihironitta
as code owners
October 25, 2022 16:10
github-actions
bot
removed
the
app (removed)
Generic label for Lightning App package
label
Oct 25, 2022
nicolai86
force-pushed
the
nicolai86/ENG-1408-ssh-key-mgmt
branch
from
October 25, 2022 16:39
e87f6a2
to
6b7d9ac
Compare
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Oct 25, 2022
awaelchli
reviewed
Oct 25, 2022
as discussed with Adrian, we want to adopt "lightning add" and "lightning remove" for ssh-keys, as the resource already exists.
nicolai86
force-pushed
the
nicolai86/ENG-1408-ssh-key-mgmt
branch
from
October 25, 2022 19:01
6b7d9ac
to
8b5a264
Compare
nicolai86
force-pushed
the
nicolai86/ENG-1408-ssh-key-mgmt
branch
from
October 25, 2022 20:38
544726a
to
087175f
Compare
12 tasks
awaelchli
approved these changes
Oct 26, 2022
Co-authored-by: Adrian Wälchli <[email protected]>
for more information, see https://pre-commit.ci
manskx
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds three new CLI commands enabling users to manage their SSH keys for lightning cloud and BYOC.
There will be a separate follow-up PR to document this functionality properly.
As SSH support is disabled via a feature flag these can be split up.
This was discussed with @awaelchli who in turn also touched base with Will:
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda