-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for local connect terminal context #15241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Oct 21, 2022
awaelchli
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid UX improvement!
…g-AI/lightning into implement_local_context
lantiga
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Approving pending addition of psutil
The CI shall be fixed with #15259 |
manskx
approved these changes
Oct 24, 2022
tchaton
requested review from
williamFalcon,
Borda,
kaushikb11 and
rohitgr7
as code owners
October 24, 2022 16:06
carmocca
approved these changes
Oct 24, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
…g-AI/lightning into implement_local_context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
bug
Something isn't working
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for having a terminal-based context for the LightningCLI. This works by adding the paren pid in the connection folder.
Furthermore, every time a command runs, it will clean out the dead connections.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda