Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for local connect terminal context #15241

Merged
merged 28 commits into from
Oct 24, 2022
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 21, 2022

What does this PR do?

This PR adds support for having a terminal-based context for the LightningCLI. This works by adding the paren pid in the connection folder.

Furthermore, every time a command runs, it will clean out the dead connections.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 21, 2022
@tchaton tchaton self-assigned this Oct 21, 2022
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid UX improvement!

src/lightning_app/cli/commands/connection.py Show resolved Hide resolved
src/lightning_app/cli/commands/connection.py Outdated Show resolved Hide resolved
@tchaton tchaton requested a review from hhsecond as a code owner October 21, 2022 17:36
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Approving pending addition of psutil

src/lightning_app/cli/commands/connection.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2022
@tchaton tchaton enabled auto-merge (squash) October 21, 2022 18:26
@tchaton tchaton added this to the v1.8 milestone Oct 21, 2022
@Borda
Copy link
Member

Borda commented Oct 23, 2022

The CI shall be fixed with #15259

.azure/app-cloud-e2e.yml Outdated Show resolved Hide resolved
requirements/app/base.txt Outdated Show resolved Hide resolved
@lexierule lexierule disabled auto-merge October 24, 2022 17:27
@lexierule lexierule merged commit f98de62 into master Oct 24, 2022
@lexierule lexierule deleted the implement_local_context branch October 24, 2022 17:27
@tchaton tchaton added the bug Something isn't working label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants