Prevent bug when launching apps on multiple clusters #15226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
luca3rd
force-pushed
the
ENG-497-bug]-can-t-run-app-on-a-cluster-if-it-already-run-in-another
branch
from
c67aed8 to
b0fb647
Compare
for more information, see https://pre-commit.ci
luca3rd
changed the title
luca3rd
changed the title
luca3rd
requested review from
tchaton,
awaelchli,
manskx,
hhsecond and
lantiga
as code owners
|
Let's also add a changelog entry in src/lightning_app/changelog.md? |
hhsecond
approved these changes
Oct 24, 2022
manskx
approved these changes
Oct 24, 2022
…-it-already-run-in-another
…-it-already-run-in-another
…-it-already-run-in-another
…-it-already-run-in-another
…-it-already-run-in-another
luca3rd
deleted the
ENG-497-bug]-can-t-run-app-on-a-cluster-if-it-already-run-in-another
branch
12 tasks
tchaton
reviewed
Oct 28, 2022
| @@ -305,6 +292,15 @@ def dispatch( | |||
|
|
|||
| if find_instances_resp.lightningapps: | |||
| existing_instance = find_instances_resp.lightningapps[0] | |||
|
|
|||
| # TODO: support multiple instances / 1 instance per cluster | |||
| if existing_instance.spec.cluster_id != cluster_id: | |||
There was a problem hiding this comment.
@luca3rd I am confused about this. If the app already exists on a cluster, than it means the user is going to restart it when a new release.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops a bug when cross-launching an app between clusters.
Currently the platform does not allow running multiple app instances. If you have
app-1running oncluster-1and try to run it oncluster-2, the CLI will succeed but the app will never start.This PR prevents this disconnect. The app should not be uploaded / released if it won't run. An error is presented to the user explaining what happened and how to proceed (specify a different
--name: e.g.app-2).Once the platform supports multiple app instances / running individual apps on multiple clusters, this PR can be reverted.
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda