Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Pass LightningWork to LightningApp #15215

Merged
merged 8 commits into from
Oct 20, 2022
Merged

[App] Pass LightningWork to LightningApp #15215

merged 8 commits into from
Oct 20, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 20, 2022 •
edited by Borda
Loading

What does this PR do?

This feature was requested by @williamFalcon and enables passing work to the LightningApp as well as a flow.

This meant mainly removing boilerplate from documentation examples.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 20, 2022
@tchaton tchaton added the priority: 0 High priority task label Oct 20, 2022
@tchaton tchaton changed the title Pass LightningWork to LightningApp [App] Pass LightningWork to LightningApp Oct 20, 2022
lantiga
lantiga approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2022
@Borda Borda requested a review from hhsecond October 20, 2022 13:32
@Borda Borda added this to the v1.8 milestone Oct 20, 2022
@lantiga lantiga merged commit 8ec7ddf into master Oct 20, 2022
@lantiga lantiga deleted the add_support_for_starting_works branch October 20, 2022 14:18
Borda pushed a commit that referenced this pull request Oct 20, 2022
@tchaton @Borda
[App] Pass LightningWork to LightningApp (#15215)
37452e8 
* update

* update

* update

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* ll

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: Luca Antiga <[email protected]>

(cherry picked from commit 8ec7ddf)
williamFalcon pushed a commit that referenced this pull request Oct 20, 2022
@Borda @tchaton
addition to App 0.7 (#15219)
65d29f0 
[App] Pass LightningWork to LightningApp (#15215)

* update

* update

* update

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* ll

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka <[email protected]>
Co-authored-by: Luca Antiga <[email protected]>

(cherry picked from commit 8ec7ddf)

Co-authored-by: thomas chaton <[email protected]>
@tchaton tchaton added the bug Something isn't working label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhsecond hhsecond hhsecond approved these changes

@Borda Borda Borda approved these changes

@lantiga lantiga lantiga approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@manskx manskx Awaiting requested review from manskx

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@tchaton @lantiga @Borda @hhsecond